Conversation
This reverts commit 176da26.
|
Duplicate of #40424 ? |
|
You are right. Closing. |
|
I am thinking of a fix for the VS issue. Some thoughts:
When I build a .NET Core component on Is that an unrealistic goal?
VS is an x86-only process, right? Not x64, and not arm64, right? Would it make sense to assume "if we are building in Visual Studio, set the architecture to x64 otherwise use the current processor's architecture"? |
|
I agree with @omajid that it would be nice if It would be ideal if VS can always be explicit about architecture. But if that is difficult, I think we can always handle it as special case e.g. Windows x86 vs x64. |
|
Here's another attempt at this: #40453 I dont have access to VS to verify this, unfortunately. |
Reverts #40311
FYI @ViktorHofer @wfurt @omajid @jozkee
I'm reverting this PR as it broke our VS scenario. Basically by default, we always built targeting x64, but because VS runs as an x86 process, we are now picking a different configuration when building inside VS. This is causing for all of our tests to break, as now you won't be able to build and run tests from VS. I'm not sure what was the main reasoning behind the original change, since I assumed that you could achieve the same thing by simply passing in ArchGroup when calling ./build.sh and that would allow you to control how to build in a hosted environment. Anyways, I'm revering this now in order to unblock devs broken trying to run tests in VS now, @omajid but feel free to submit a new PR taking this problem in consideration.