This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Enable build on hosted arm64#40311
Merged
ViktorHofer merged 1 commit intodotnet:masterfrom Aug 16, 2019
Merged
Conversation
Initialize HostArch to the arch-style used in RIDs directly. Initialize ArchGroup to HostArch unless overriden. Use the HostArch for the tool runtime instead of assuming x64.
Member
Author
|
cc'ing some folks who have touched this code for a review: @safern @wfurt @tmds @ViktorHofer @ericstj |
krwq
reviewed
Aug 15, 2019
| <ArchGroup Condition="'$(ArchGroup)' == '' AND '$(HostArch)' == 'Arm'">arm</ArchGroup> | ||
| <ArchGroup Condition="'$(ArchGroup)' == '' AND '$(HostArch)' == 'Arm64'">arm64</ArchGroup> | ||
| <ArchGroup Condition="'$(ArchGroup)' == ''">x64</ArchGroup> | ||
| <HostArch>$([System.Runtime.InteropServices.RuntimeInformation]::ProcessArchitecture.ToString().ToLowerInvariant())</HostArch> |
Member
There was a problem hiding this comment.
I'm wondering if API should be doing ToLower instead (fine in this PR though)
Member
There was a problem hiding this comment.
that would be probably considered breaking change so it may be too late for that.
wfurt
approved these changes
Aug 15, 2019
Member
wfurt
left a comment
There was a problem hiding this comment.
LGTM.
When I was trying this while back I saw crashes and instability but maybe we improved over time.
ViktorHofer
approved these changes
Aug 16, 2019
ViktorHofer
added a commit
to ViktorHofer/corefx
that referenced
this pull request
Aug 19, 2019
This reverts commit 176da26.
ViktorHofer
added a commit
that referenced
this pull request
Aug 20, 2019
omajid
added a commit
to omajid/dotnet-corefx
that referenced
this pull request
Aug 20, 2019
Initialize HostArch to the arch-style used in RIDs directly. Unless running in Visual Studio, when it should be forced to x64. Initialize ArchGroup to HostArch unless overriden. Use the HostArch for the tool runtime instead of assuming x64.
jozkee
added a commit
to jozkee/corefx
that referenced
this pull request
Aug 22, 2019
This reverts commit 176da26.
jozkee
added a commit
to jozkee/corefx
that referenced
this pull request
Aug 22, 2019
This reverts commit ecd71d3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the right RID for the tools on arm64.
With this change, I can build corefx on RHEL 8 on arm64 (hosted, not cross-compiled).