This repository was archived by the owner on Jan 23, 2023. It is now read-only.
HTTP2: Ensure we don't try to send RST_STREAM or EndStream while holding the stream lock#40123
Merged
geoffkizer merged 1 commit intodotnet:masterfrom Aug 9, 2019
Merged
Conversation
stephentoub
reviewed
Aug 9, 2019
src/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Stream.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Aug 9, 2019
geoffkizer
added a commit
to geoffkizer/corefx
that referenced
this pull request
Aug 9, 2019
danmoseley
pushed a commit
that referenced
this pull request
Aug 9, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
… stream lock (dotnet/corefx#40123) Commit migrated from dotnet/corefx@719b8fb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40115
Sending a frame -- specifically, calling SendRstStreamAsync or SendEndStreamAsync -- can fail, which causes active streams to be aborted. Avoid doing this under the stream lock, to prevent lock reentrancy issues.
@danmosemsft This will need to get ported to 3.0