This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix NullReferenceExceptions in IndentedTextWriter without writer#39584
Merged
stephentoub merged 1 commit intodotnet:masterfrom Jul 21, 2019
hughbe:fix-nre-indentedwriter
Merged
Fix NullReferenceExceptions in IndentedTextWriter without writer#39584stephentoub merged 1 commit intodotnet:masterfrom hughbe:fix-nre-indentedwriter
stephentoub merged 1 commit intodotnet:masterfrom
hughbe:fix-nre-indentedwriter
Conversation
stephentoub
approved these changes
Jul 18, 2019
Member
stephentoub
left a comment
There was a problem hiding this comment.
LGTM. @JeremyKuhne, are you ok with this change? Technically it's breaking (e.g. someone constructing an IndentedTextWriter with null and then never using it will now see exceptions they didn't before, and even if they do use it, the exception will now be in a different place), but I agree with @hughbe that the revised behavior is better.
Member
Yes, much better to get the error up front. |
Member
|
/azp run corefx-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wouldn't throw NREs in the constructor but whenever any method was called on
IndentedTextWriter. Fix this to validate in the constructor