This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Change callbacks to virtual from being abstract#39526
Merged
Conversation
- Obsolete the callbacks as well
stephentoub
reviewed
Jul 16, 2019
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Member
Author
jkotalik
approved these changes
Jul 16, 2019
|
"This will be removed in a future release." - I'm willing to bet it never will be, but I think that messaging is necessary to suitably dissuade folks |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
- Obsolete the callbacks as well Commit migrated from dotnet/corefx@51cd784
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38362