This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Propagate abort exceptions from CreditManager.Dispose#39520
Merged
stephentoub merged 1 commit intodotnet:masterfrom Jul 16, 2019
Merged
Propagate abort exceptions from CreditManager.Dispose#39520stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
Currently, if an abort occurs, it disposes of credit managers, and if there's a waiter on that credit manager, that waiter propagates an ObjectDisposedException. It should instead propagate whatever exception resulted from the abort.
geoffkizer
approved these changes
Jul 16, 2019
davidsh
reviewed
Jul 16, 2019
src/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/CreditManager.cs
Show resolved
Hide resolved
davidsh
approved these changes
Jul 16, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…39520) Currently, if an abort occurs, it disposes of credit managers, and if there's a waiter on that credit manager, that waiter propagates an ObjectDisposedException. It should instead propagate whatever exception resulted from the abort. Commit migrated from dotnet/corefx@3c71b23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if an abort occurs, it disposes of credit managers, and if there's a waiter on that credit manager, that waiter propagates an ObjectDisposedException. It should instead propagate whatever exception resulted from the abort.
Fixes https://github.com/dotnet/corefx/issues/39511
cc: @geoffkizer, @scalablecory, @davidsh, @eiriktsarpalis, @wfurt