This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add tests for nullable metadata and unconditionally set nullablePublicOnly#39395
Merged
safern merged 4 commits intodotnet:masterfrom Jul 15, 2019
Merged
Add tests for nullable metadata and unconditionally set nullablePublicOnly#39395safern merged 4 commits intodotnet:masterfrom
safern merged 4 commits intodotnet:masterfrom
Conversation
Member
Author
|
Note, this is easier to review by commits, the last commit is just a pure darc update for arcade. |
ViktorHofer
reviewed
Jul 11, 2019
ViktorHofer
approved these changes
Jul 11, 2019
ViktorHofer
reviewed
Jul 11, 2019
ViktorHofer
reviewed
Jul 11, 2019
8850cdc to
875cc4d
Compare
stephentoub
reviewed
Jul 11, 2019
stephentoub
reviewed
Jul 11, 2019
Member
Author
|
I've added positive tests and made them a Theory to validate with multiple types. PTAL. |
6895bfa to
2922b7b
Compare
2922b7b to
31a8ad2
Compare
danmoseley
reviewed
Jul 15, 2019
danmoseley
approved these changes
Jul 15, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…cOnly (dotnet/corefx#39395) * Add tests for nullable compiler emitted attributes * Set nullablePublicOnly compiler feature unconditionally * PR Feedback * PR Feedback -- add positive and more exhaustive tests Commit migrated from dotnet/corefx@08cd402
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This consumes the new compiler which now only emits the
NullablePublicOnlyAttributeinto the module only if it is actually needed and I also added tests to make sure the facades doesn't have any type definitions nor this attribute, plus tests to make sure that internal APIs doesn't get nullable attributes.Fixes: #39175
cc: @stephentoub @ericstj @ViktorHofer