This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Use Uri.OriginalString when serializing#39015
Merged
JeremyKuhne merged 2 commits intodotnet:masterfrom Jul 8, 2019
Merged
Conversation
layomia
approved these changes
Jun 28, 2019
stephentoub
reviewed
Jun 28, 2019
Contributor
|
I made the comment on the original work by @layomia that I believe perhaps AbsoluteUri's documentation was copied as the start for OriginalString, which included the exception. |
ahsonkhan
reviewed
Jun 28, 2019
ahsonkhan
approved these changes
Jun 28, 2019
We want to be lossless if possible when round tripping (outside of escaping). To do so we need to write OriginalString instead of using ToString(). Removing pending issue reference as it was closed (we won't be adding a Uri parser to the reader). Add user reported scenario.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Use Uri.OriginalString when serializing We want to be lossless if possible when round tripping (outside of escaping). To do so we need to write OriginalString instead of using ToString(). Removing pending issue reference as it was closed (we won't be adding a Uri parser to the reader). Add user reported scenario. * Address feedback Commit migrated from dotnet/corefx@398dc98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to be lossless if possible when round tripping (outside of escaping). To do so we need to write OriginalString instead of using ToString().
Removing pending issue reference as it was closed (we won't be adding a Uri parser to the reader).
Add user reported scenario. #38568