This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add unit tests for EncoderNLS / DecoderNLS fallbacks#38937
Merged
GrabYourPitchforks merged 5 commits intodotnet:masterfrom Jul 1, 2019
Merged
Add unit tests for EncoderNLS / DecoderNLS fallbacks#38937GrabYourPitchforks merged 5 commits intodotnet:masterfrom
GrabYourPitchforks merged 5 commits intodotnet:masterfrom
Conversation
e436dda to
d944f8e
Compare
tarekgh
approved these changes
Jun 26, 2019
stephentoub
reviewed
Jun 26, 2019
Member
Author
|
Failing tests are unrelated. Going forward with merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to https://github.com/dotnet/corefx/issues/37969. Unit tests will not pass until dotnet/coreclr#25397 is merged and makes its way over to corefx.