This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Enforce JsonSerializerOptions.MaxDepth on write#38706
Merged
steveharter merged 2 commits intodotnet:masterfrom Jun 20, 2019
Merged
Enforce JsonSerializerOptions.MaxDepth on write#38706steveharter merged 2 commits intodotnet:masterfrom
steveharter merged 2 commits intodotnet:masterfrom
Conversation
ahsonkhan
reviewed
Jun 20, 2019
src/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs
Show resolved
Hide resolved
ahsonkhan
reviewed
Jun 20, 2019
|
|
||
| { | ||
| var options = new JsonSerializerOptions(); | ||
| options.MaxDepth = depth + 1; |
There was a problem hiding this comment.
What happens if a user sets this to 900-1000 or even larger?
Contributor
Author
There was a problem hiding this comment.
If larger, the 1,000 limit on the writer will kick in.
There was a problem hiding this comment.
Hmm... So, we can't serialize any objects > 64 depth, even though we can write JSON with depth > 64? Seems like the limitation is too strict here.
ahsonkhan
reviewed
Jun 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/36510
It appears the
Utf8JsonWriternow has an upper limit of 1,000 so we would never get aStackOverflowException.