This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Socket.Tests: add CanceledByDispose tests#37706
Closed
tmds wants to merge 7 commits intodotnet:masterfrom
Closed
Conversation
Member
Author
|
Member
Author
It's not clear why this is timing out. Nothing useful in the logs. There doesn't seem to be a log that shows the console output from the test run. Or I don't know how to find it. |
tmds
added a commit
to tmds/corefx
that referenced
this pull request
May 20, 2019
Member
Author
|
CI results summarized here:#37486 (comment) |
davidsh
pushed a commit
that referenced
this pull request
Jun 20, 2019
* Socket: Linux: unblock synchronous socket operations on Dispose * Fix windows build * TryUnblockSocket: always do an abortive close for TCP * TryUnblockSocket: experiment, always call Shutdown * SyncTcpReceiveSendGetsCancelledByDisposeOrClose: Don't check for abortive close * Fix build * Revert always shutdown to compare CI results * PR feedback * TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race * TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race II * Fix test * TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race III * TcpReceiveSendGetsCanceledByDisposeOrClose: only run on Sync * Also perform abortive close when canceling async send/receive * Fix aborted set to true * Check what fails on OSX with Shutdown * Revert "Check what fails on OSX with Shutdown" This reverts commit 5ab7fce. * Don't perform abortive close for operations that were already canceled * interrup Accept/Listen on OSX * Find out what Disconnectx does for different tests on CI machines * Move Linux connect AF_UNSPEC and OSX disconnectx into pal Disconnect function, update tests for OSX * Trigger CI * TcpReceiveSendGetsCanceledByDispose: check SocketErrorCode * TcpReceiveSendGetsCanceledByDispose: OSX is also performing an RST close for disconnectx * Revert "TcpReceiveSendGetsCanceledByDispose: OSX is also performing an RST close for disconnectx" This reverts commit a8d5b02. * TcpReceiveSendGetsCanceledByDispose: fix test for OSX * call CancelIoEx to kick out pending operations * Socket interop: replace IntPtr with SafeHandle * Windows: RST close when operations were canceled * Extend tests to check local SocketError * test: update expected SocketErrors * update tests: Apm API throws ObjectDisposedException instead of SocketException * Extend asserts * Update expected result for ConnectTask * Update tests based on Windows behavior (#37706) * Map SocketErrors in Socket.cs * Rewrite nullable asserts * Fix test for Mac * Handle SendFile SocketError * SyncSendFileGetsCanceledByDispose: change how we generate the large file * SyncSendFileGetsCanceledByDispose: ensure unique filename * Fix NETFX build * SyncSendFileGetsCanceledByDispose: skip on NetFramework * PR feedback * Fix broken build * Perform DangerousAddRef for Socket used with UpdateAcceptContext socket option
steveharter
pushed a commit
to steveharter/dotnet_corefx
that referenced
this pull request
Jun 25, 2019
…et#37486) * Socket: Linux: unblock synchronous socket operations on Dispose * Fix windows build * TryUnblockSocket: always do an abortive close for TCP * TryUnblockSocket: experiment, always call Shutdown * SyncTcpReceiveSendGetsCancelledByDisposeOrClose: Don't check for abortive close * Fix build * Revert always shutdown to compare CI results * PR feedback * TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race * TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race II * Fix test * TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race III * TcpReceiveSendGetsCanceledByDisposeOrClose: only run on Sync * Also perform abortive close when canceling async send/receive * Fix aborted set to true * Check what fails on OSX with Shutdown * Revert "Check what fails on OSX with Shutdown" This reverts commit 5ab7fce. * Don't perform abortive close for operations that were already canceled * interrup Accept/Listen on OSX * Find out what Disconnectx does for different tests on CI machines * Move Linux connect AF_UNSPEC and OSX disconnectx into pal Disconnect function, update tests for OSX * Trigger CI * TcpReceiveSendGetsCanceledByDispose: check SocketErrorCode * TcpReceiveSendGetsCanceledByDispose: OSX is also performing an RST close for disconnectx * Revert "TcpReceiveSendGetsCanceledByDispose: OSX is also performing an RST close for disconnectx" This reverts commit a8d5b02. * TcpReceiveSendGetsCanceledByDispose: fix test for OSX * call CancelIoEx to kick out pending operations * Socket interop: replace IntPtr with SafeHandle * Windows: RST close when operations were canceled * Extend tests to check local SocketError * test: update expected SocketErrors * update tests: Apm API throws ObjectDisposedException instead of SocketException * Extend asserts * Update expected result for ConnectTask * Update tests based on Windows behavior (dotnet#37706) * Map SocketErrors in Socket.cs * Rewrite nullable asserts * Fix test for Mac * Handle SendFile SocketError * SyncSendFileGetsCanceledByDispose: change how we generate the large file * SyncSendFileGetsCanceledByDispose: ensure unique filename * Fix NETFX build * SyncSendFileGetsCanceledByDispose: skip on NetFramework * PR feedback * Fix broken build * Perform DangerousAddRef for Socket used with UpdateAcceptContext socket option
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…et/corefx#37486) * Socket: Linux: unblock synchronous socket operations on Dispose * Fix windows build * TryUnblockSocket: always do an abortive close for TCP * TryUnblockSocket: experiment, always call Shutdown * SyncTcpReceiveSendGetsCancelledByDisposeOrClose: Don't check for abortive close * Fix build * Revert always shutdown to compare CI results * PR feedback * TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race * TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race II * Fix test * TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race III * TcpReceiveSendGetsCanceledByDisposeOrClose: only run on Sync * Also perform abortive close when canceling async send/receive * Fix aborted set to true * Check what fails on OSX with Shutdown * Revert "Check what fails on OSX with Shutdown" This reverts commit dotnet/corefx@5ab7fce. * Don't perform abortive close for operations that were already canceled * interrup Accept/Listen on OSX * Find out what Disconnectx does for different tests on CI machines * Move Linux connect AF_UNSPEC and OSX disconnectx into pal Disconnect function, update tests for OSX * Trigger CI * TcpReceiveSendGetsCanceledByDispose: check SocketErrorCode * TcpReceiveSendGetsCanceledByDispose: OSX is also performing an RST close for disconnectx * Revert "TcpReceiveSendGetsCanceledByDispose: OSX is also performing an RST close for disconnectx" This reverts commit dotnet/corefx@a8d5b02. * TcpReceiveSendGetsCanceledByDispose: fix test for OSX * call CancelIoEx to kick out pending operations * Socket interop: replace IntPtr with SafeHandle * Windows: RST close when operations were canceled * Extend tests to check local SocketError * test: update expected SocketErrors * update tests: Apm API throws ObjectDisposedException instead of SocketException * Extend asserts * Update expected result for ConnectTask * Update tests based on Windows behavior (dotnet/corefx#37706) * Map SocketErrors in Socket.cs * Rewrite nullable asserts * Fix test for Mac * Handle SendFile SocketError * SyncSendFileGetsCanceledByDispose: change how we generate the large file * SyncSendFileGetsCanceledByDispose: ensure unique filename * Fix NETFX build * SyncSendFileGetsCanceledByDispose: skip on NetFramework * PR feedback * Fix broken build * Perform DangerousAddRef for Socket used with UpdateAcceptContext socket option Commit migrated from dotnet/corefx@3fac6ad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes tests from #37486 to see CI result on Windows without the functional changes. This is not for merging.