This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Mark System.Reflection.Emit* as inbox on netstandard2.1#37532
Merged
wtgodbe merged 1 commit intodotnet:masterfrom May 16, 2019
Merged
Mark System.Reflection.Emit* as inbox on netstandard2.1#37532wtgodbe merged 1 commit intodotnet:masterfrom
wtgodbe merged 1 commit intodotnet:masterfrom
Conversation
Member
Author
|
Weird, lots of test infrastructure failures here (couldn't download a .zip payload, etc.). I'll try re-running, then investigate. |
ericstj
approved these changes
May 9, 2019
Member
ericstj
left a comment
There was a problem hiding this comment.
Changes look good, let's wait to merge until we ingest the new standard repo package with the shims.
Member
Author
|
MUSL failure is a known issue, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet/standard#1180 adds inbox shims for RefEmit, once we merge that PR we should mark RefEmit as inbox for netstandard2.1.
@ericstj PTAL