This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Making BaseNumberConverter Internal#37278
Merged
Anipik merged 3 commits intodotnet:masterfrom Apr 29, 2019
Anipik:baseNumberConverter
Merged
Making BaseNumberConverter Internal#37278Anipik merged 3 commits intodotnet:masterfrom Anipik:baseNumberConverter
Anipik merged 3 commits intodotnet:masterfrom
Anipik:baseNumberConverter
Conversation
jkotas
approved these changes
Apr 29, 2019
stephentoub
approved these changes
Apr 29, 2019
ericstj
reviewed
Apr 30, 2019
| MembersMustExist : Member 'System.Security.Cryptography.Pkcs.CmsSigner.SignedAttributes.set(System.Security.Cryptography.CryptographicAttributeObjectCollection)' does not exist in the implementation but it does exist in the contract. | ||
| MembersMustExist : Member 'System.Security.Cryptography.Pkcs.CmsSigner.UnsignedAttributes.set(System.Security.Cryptography.CryptographicAttributeObjectCollection)' does not exist in the implementation but it does exist in the contract. | ||
| Total Issues: 21 | ||
| Compat issues with assembly System.ComponentModel.TypeConverter: |
Member
There was a problem hiding this comment.
@terrajobst we should fix this in the standard repo as well.
jonpryor
added a commit
to xamarin/xamarin-android-api-compatibility
that referenced
this pull request
Jun 12, 2019
Context: https://github.com/dotnet/corefx/issues/35924 Context: dotnet/corefx#37278 Context: dotnet/standard#1171 Context: dotnet/android@ce4eeb4 Context: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/561/API_20Compatibility_20Checks/ Commit xamarin/xamarin-android/master@ce4eeb4f introduced API breakage within `System.dll`: the [`System.ComponentModel.BaseNumberConverter` default constructor][0] was ***removed***: <h3>Type Changed: System.ComponentModel.BaseNumberConverter</h3> <p>Removed constructor:</p> <pre> <span class='removed removed-constructor breaking' data-is-breaking>protected BaseNumberConverter ();</span> </pre> On the surface this looks like a questionable API break. However, consider the [`BaseNumberConverter` source code][1], which contains `internal abstract` members: partial abstract class BaseNumberConverter { internal abstract Type TargetType { get; } internal abstract object FromString(string value, int radix); // ... } The existence of these `internal abstract` members means that the type cannot possibly be inherited by a non-`abstract` class, nor can such a subclass be instantiated via `new` expression. This in turn means that the "breakage" of removing the default constructor is non- existent; it cannot possibly break existing code. Remove the `BaseNumberConverter` default constructor, so that we no longer flag it as API breakage. [0]: https://docs.microsoft.com/en-us/dotnet/api/system.componentmodel.basenumberconverter.-ctor?view=netframework-4.8#System_ComponentModel_BaseNumberConverter__ctor [1]: https://github.com/dotnet/corefx/blob/master/src/System.ComponentModel.TypeConverter/src/System/ComponentModel/BaseNumberConverter.cs
jonpryor
added a commit
to xamarin/xamarin-android-api-compatibility
that referenced
this pull request
Jun 13, 2019
Context: https://github.com/dotnet/corefx/issues/35924 Context: dotnet/corefx#37278 Context: dotnet/standard#1171 Context: dotnet/android@ce4eeb4 Context: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/561/API_20Compatibility_20Checks/ Commit xamarin/xamarin-android/master@ce4eeb4f introduced API breakage within `System.dll`: the [`System.ComponentModel.BaseNumberConverter` default constructor][0] was ***removed***: <h3>Type Changed: System.ComponentModel.BaseNumberConverter</h3> <p>Removed constructor:</p> <pre> <span class='removed removed-constructor breaking' data-is-breaking>protected BaseNumberConverter ();</span> </pre> On the surface this looks like a questionable API break. However, consider the [`BaseNumberConverter` source code][1], which contains `internal abstract` members: partial abstract class BaseNumberConverter { internal abstract Type TargetType { get; } internal abstract object FromString(string value, int radix); // ... } The existence of these `internal abstract` members means that the type cannot possibly be inherited by a non-`abstract` class, nor can such a subclass be instantiated via `new` expression. This in turn means that the "breakage" of removing the default constructor is non- existent; it cannot possibly break existing code. Remove the `BaseNumberConverter` default constructor, so that we no longer flag it as API breakage. [0]: https://docs.microsoft.com/en-us/dotnet/api/system.componentmodel.basenumberconverter.-ctor?view=netframework-4.8#System_ComponentModel_BaseNumberConverter__ctor [1]: https://github.com/dotnet/corefx/blob/master/src/System.ComponentModel.TypeConverter/src/System/ComponentModel/BaseNumberConverter.cs
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* type converter ctor made internal * diasabling apicompat for the change * Fixing uap app compat Commit migrated from dotnet/corefx@fe807da
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/dotnet/corefx/issues/35924
Technically it is a breaking change but there is no way to derive and instantiate this class. An exception will get thrown if we will try to instantiate the derived class.
I am making this internal and not private because a bunch of classes are deriving it.
I will also make a change a arcade repo to help avoid these scenarios