This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Cleanup SocketOptionNameTest#36864
Merged
stephentoub merged 1 commit intodotnet:masterfrom Apr 15, 2019
Merged
Conversation
One of the oldest issues #4887 was about the Windows socket option, ReuseUnicastPort. This test was disabled several years ago because it was very difficult to test in CI since it required not only a newer version of Windows but also specific network settings on the machine. At this point, there is not any way to reliably test this. And the end-to-end test isn't really of high value for .NET Core since we would really be mostly testing an OS feature. As part of cleaning that issue up, I cleaned up the rest of the tests, some of which were marked as Outerloop but didn't need to be. Closes #29929 Closes #21327 Closes #4887
stephentoub
approved these changes
Apr 15, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
One of the oldest issues dotnet/corefx#4887 was about the Windows socket option, ReuseUnicastPort. This test was disabled several years ago because it was very difficult to test in CI since it required not only a newer version of Windows but also specific network settings on the machine. At this point, there is not any way to reliably test this. And the end-to-end test isn't really of high value for .NET Core since we would really be mostly testing an OS feature. As part of cleaning that issue up, I cleaned up the rest of the tests, some of which were marked as Outerloop but didn't need to be. Closes dotnet/corefx#29929 Closes dotnet/corefx#21327 Closes dotnet/corefx#4887 Commit migrated from dotnet/corefx@f389a14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the oldest issues #4887 was about the Windows socket option, ReuseUnicastPort.
This test was disabled several years ago because it was very difficult to test in CI since it
required not only a newer version of Windows but also specific network settings on the machine.
At this point, there is not any way to reliably test this. And the end-to-end test isn't really
of high value for .NET Core since we would really be mostly testing an OS feature.
As part of cleaning that issue up, I cleaned up the rest of the tests, some of which were marked
as Outerloop but didn't need to be.
Closes #29929
Closes #21327
Closes #4887