Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Auto-generate the reference assemblies and separate type forwards #35557

Merged
ahsonkhan merged 20 commits into from
Feb 28, 2019
Merged

Auto-generate the reference assemblies and separate type forwards #35557

ahsonkhan merged 20 commits into from
Feb 28, 2019

Conversation

@ahsonkhan
Copy link

@ahsonkhan ahsonkhan commented Feb 25, 2019

Context from #35474 (comment)

  • One big PR that just fixes the formatting and that is verified to be zero-diff in generated binaries. This PR does not need reviewing.

Auto-generated the reference assemblies using /t:GenerateReferenceSource on all projects that already contained a /ref/ directory.
https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/updating-ref-source.md

The goal is to normalize the reference assembly, so that subsequent "real" changes are easier to review.

Partially addresses https://github.com/dotnet/corefx/issues/29737

There is no additional/removal of APIs in this change. The diff between this PR and master is empty.

cc @jkotas, @stephentoub, @ericstj, @danmosemsft, @bartonjs

@ahsonkhan ahsonkhan added this to the 3.0 milestone Feb 25, 2019
@ahsonkhan ahsonkhan self-assigned this Feb 25, 2019
@ahsonkhan ahsonkhan mentioned this pull request Feb 25, 2019
Closed
ahsonkhan
ahsonkhan commented Feb 25, 2019
View reviewed changes
ahsonkhan
ahsonkhan commented Feb 25, 2019
View reviewed changes
ahsonkhan
ahsonkhan commented Feb 25, 2019
View reviewed changes
ahsonkhan
ahsonkhan commented Feb 25, 2019
View reviewed changes
@jkotas
Copy link
Member

jkotas commented Feb 25, 2019

The diff between this PR and master is empty.

What is the diff that you have checked?

This does look like a zero-diff in generate binaries because of you are removing some attributes.

@GrabYourPitchforks GrabYourPitchforks mentioned this pull request Feb 25, 2019
Merged
@ahsonkhan
Copy link
Author

ahsonkhan commented Feb 27, 2019 •
edited
Loading

What is the diff that you have checked?

I checked the APIs under bin\ref\netcoreapp3.0 using the API Reviewer.

This does look like a zero-diff in generate binaries because of you are removing some attributes.

API reviewer wasn't capturing attribute changes.

The diff between this PR and master is empty.

To validate, I ran API Compat against master and this branch and fixed remaining attribute issues that came up from that. For netcoreapp3.0/some uap refs, there are no api compat issues from this change. For netfx (specifically), there are some issues around assembly Microsoft.VisualC.STLCLR but I am not sure where that's coming from since I am not modifying anything related to that assembly. I'll re-sync with master and check if this issue still exists.

ericstj
ericstj reviewed Feb 27, 2019
View reviewed changes
src/System.Xml.XmlDocument/ref/System.Xml.XmlDocument.cs
@@ -1,27 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
// ------------------------------------------------------------------------------
Copy link
Member

@ericstj ericstj Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: empty file

ericstj
ericstj approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've spot checked the diff and looked through for some specific issues and it seems ok. Please be sure to run API-compat runs on the ref folders to ensure things are clean. Consider inverse runs as well since you expect this to have no changes backwards as well.

@ahsonkhan ahsonkhan mentioned this pull request Feb 27, 2019
Closed
@ahsonkhan
Copy link
Author

ahsonkhan commented Feb 27, 2019 •
edited
Loading

Please be sure to run API-compat runs on the ref folders to ensure things are clean. Consider inverse runs as well since you expect this to have no changes backwards as well.

I compared all the refs except netcoreapp and uap (+ inverse) for master vs branch. The netcoreapp/uap ones are blocked on dotnet/arcade#2122

I was able to run the ApiCompat on smaller chunks of the ref.

For netfx (net45 to net471) there is some compat issue with Microsoft.VisualC.STLCLR. This compat issue doesn't exist on net472.
ApiCompatDiff.txt

@ahsonkhan ahsonkhan mentioned this pull request Feb 27, 2019
Open
@ahsonkhan
Copy link
Author

ahsonkhan commented Feb 27, 2019

Any other feedback or can I merge this in now?

@ahsonkhan
Copy link
Author

ahsonkhan commented Feb 27, 2019 •
edited
Loading

The netcoreapp/uap ones are blocked

Verified with dotnet/arcade#2133 that there are no ApiCompat issues for those either.

@ahsonkhan ahsonkhan mentioned this pull request Feb 28, 2019
Closed
@ahsonkhan
Copy link
Author

ahsonkhan commented Feb 28, 2019

For netfx (net45 to net471) there is some compat issue with Microsoft.VisualC.STLCLR.

dotnet/arcade#2136

@ahsonkhan ahsonkhan merged commit 16689aa into dotnet:master Feb 28, 2019
@ahsonkhan ahsonkhan deleted the AutoGenRefs branch February 28, 2019 03:39
@ahsonkhan ahsonkhan mentioned this pull request Feb 27, 2019
Merged
14 tasks
This was referenced Jun 23, 2019
Open
Open
@ahsonkhan ahsonkhan mentioned this pull request Feb 1, 2020
Closed
macrogreg pushed a commit to open-telemetry/opentelemetry-dotnet-instrumentation that referenced this pull request Sep 24, 2020
@ahsonkhan
Auto-generate the reference assemblies and separate type forwards (do…
4ef685a 
…tnet/corefx#35557)

* Auto-generate the reference assemblies

* Add back type forwards.

* Revert "Add back type forwards."

This reverts commit dotnet/corefx@3acf74a.

* Add back TypeForwardedTo in .Forward.cs files

* Add new type forward files to the csproj files

* Add back if-defs and move TestUtilities comment from ref to source

* Remove duplicate definitions, delete unnecessary manual files,

* Fix build breaks

* Add back missing AsyncMethodBuilderAttr to S.Runtime ref

* Fix typo between XmlDocument and XPath.XDocument

* Add type forward fild missed from previous commit

* Fix ECDiffieHellmanCngPublicKey internal ctor for netfx 4.6.1

* Remove "this type was moved to comments" from the type forwards.

* Add back the Xml and Debugger* attributes to Xml.ReaderWriter

* Add back struct layout attributes

* Add back attributes missing (highlighted from api compat)

* Add missing toolbox item attribute in s.data.common.

* Add missing struct layout attributes and remove unnecessary additions

* Add back InterfaceTypeAttribute


Commit migrated from dotnet/corefx@16689aa
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@ahsonkhan
Auto-generate the reference assemblies and separate type forwards (do…
4fed6ab 
…tnet/corefx#35557)

* Auto-generate the reference assemblies

* Add back type forwards.

* Revert "Add back type forwards."

This reverts commit dotnet/corefx@3acf74a.

* Add back TypeForwardedTo in .Forward.cs files

* Add new type forward files to the csproj files

* Add back if-defs and move TestUtilities comment from ref to source

* Remove duplicate definitions, delete unnecessary manual files,

* Fix build breaks

* Add back missing AsyncMethodBuilderAttr to S.Runtime ref

* Fix typo between XmlDocument and XPath.XDocument

* Add type forward fild missed from previous commit

* Fix ECDiffieHellmanCngPublicKey internal ctor for netfx 4.6.1

* Remove "this type was moved to comments" from the type forwards.

* Add back the Xml and Debugger* attributes to Xml.ReaderWriter

* Add back struct layout attributes

* Add back attributes missing (highlighted from api compat)

* Add missing toolbox item attribute in s.data.common.

* Add missing struct layout attributes and remove unnecessary additions

* Add back InterfaceTypeAttribute


Commit migrated from dotnet/corefx@16689aa
@jkotas jkotas mentioned this pull request May 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

5 more reviewers

@stephentoub stephentoub stephentoub left review comments

@jkotas jkotas jkotas left review comments

@tannergooding tannergooding tannergooding left review comments

@bartonjs bartonjs bartonjs left review comments

@ericstj ericstj ericstj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ahsonkhan ahsonkhan

Labels

area-Meta

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ahsonkhan @jkotas @stephentoub @ericstj @tannergooding @bartonjs