This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Omit Environment.Version from CodeDom generated files#35458
Merged
jkotas merged 3 commits intodotnet:masterfrom Feb 21, 2019
Merged
Omit Environment.Version from CodeDom generated files#35458jkotas merged 3 commits intodotnet:masterfrom
jkotas merged 3 commits intodotnet:masterfrom
Conversation
Member
Author
|
This is fixing the test failures caused by The alternative way to fix this is to update the test baseline to expect the variable version. |
stephentoub
approved these changes
Feb 20, 2019
ericstj
approved these changes
Feb 20, 2019
Member
|
You need to fix corefx/src/System.CodeDom/src/Microsoft/CSharp/CSharpCodeGenerator.cs Lines 2524 to 2526 in 6ffca61 |
2d6f9b2 to
aaab092
Compare
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Nov 25, 2020
It looks like new CodeDOM doesn't include this any more: dotnet/corefx#35458
rainersigwald
added a commit
to dotnet/msbuild
that referenced
this pull request
Dec 21, 2020
It looks like new CodeDOM doesn't include this any more: dotnet/corefx#35458
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Apr 27, 2021
It looks like new CodeDOM doesn't include this any more: dotnet/corefx#35458
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Sep 30, 2021
It looks like new CodeDOM doesn't include this any more: dotnet/corefx#35458
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…35458) * Omit Environment.Version from CodeDom generated files Contributes to dotnet/coreclr#22664 * Disable tests on .NET Framework Commit migrated from dotnet/corefx@89f72f6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/coreclr#22664