HTTP2: Modify HTTP2 tests to run against platform handlers as well#34630
HTTP2: Modify HTTP2 tests to run against platform handlers as well#34630geoffkizer merged 4 commits intodotnet:masterfrom
Conversation
|
@dotnet-bot test outerloop Linux x64 debug build |
|
@dotnet-bot test outerloop Linux x64 debug build |
2 similar comments
|
@dotnet-bot test outerloop Linux x64 debug build |
|
@dotnet-bot test outerloop Linux x64 debug build |
|
I added some basic GOAWAY tests and proper connection shutdown handling in the loopback server. |
| RstStreamFrame resetStream = new RstStreamFrame(FrameFlags.None, 0x2, streamId); | ||
| await server.WriteFrameAsync(resetStream); | ||
|
|
||
| await Assert.ThrowsAsync<HttpRequestException>(async () => await sendTask); |
There was a problem hiding this comment.
Nit: what you have is fine, but for reference this could also just be:
await Assert.ThrowsAsync<HttpRequestException>(() => sendTask);5bf4c97 to
340d2ac
Compare
|
In the interest of getting this in, I'm just disabling the platform handlers using an #if. The tests do run successfully against WinHttpHandler, but they don't run by default. We can revisit this later if desired. |
|
@dotnet-bot test outerloop Linux x64 debug build |
|
Removing the no-merge label since this is ready to merge. @dotnet/ncl please take a look. |
|
@dotnet-bot test this please |
|
@dotnet-bot test outerloop Linux x64 debug build |
|
|
||
| await server.EstablishConnectionAsync(); | ||
| await server.ReadRequestHeaderAsync(); | ||
| int streamId = await server.ReadRequestHeaderAsync(); |
There was a problem hiding this comment.
Is there any reason to add this line if we don't use the streamId?
There was a problem hiding this comment.
Not really, probably a copy-and-paste thing.
| if (!IsWinHttpHandler) | ||
| { | ||
| // The client should close the connection as this is a fatal connection level error. | ||
| Assert.Null(await server.ReadFrameAsync(TimeSpan.FromSeconds(30))); |
HTTP2: Modify HTTP2 tests to run against platform handlers as well Commit migrated from dotnet/corefx@073bf47
Currently, HTTP2 specific tests are only running against SocketsHttpHandler. Modify them to also run against platform handlers, and modify tests as appropriate to deal with differences in behavior.
I haven't tested this with CurlHandler yet; I'll look at the results of the CI pass and see what needs to be modified.
@dotnet/ncl