Address MetadataLoadContext review feedback#33992
Conversation
|
@dotnet-bot test this please |
4ce9de9 to
4a22aeb
Compare
| } | ||
| if (j == types.Length) | ||
| candidates[CurIdx++] = candidates[i]; | ||
| candidates[curIdx++] = candidates[i]; |
There was a problem hiding this comment.
I still have some nits around adding brace brackets within nested scopes (even for single line statements). What's your perspective on that?
There was a problem hiding this comment.
I am not the original author of this code; but yes I agree and would prefer more whitespace \ extra lines when it makes the code more readable.
There was a problem hiding this comment.
@ahsonkhan are you aware of any tools to help with re-formatting? The terse bracing style is pervasive here.
There was a problem hiding this comment.
Unfortunately, not :(
@stephentoub, @danmosemsft, any suggestions?
There was a problem hiding this comment.
Does VS re-factoring work for you? I tried it out at a document level and it worked reasonably well. You may want to undo some of the braces, but that might be less work than adding the braces (depending on how pervasive either formatting is and when you want to opt out of braces).
|
test Linux x64 Release Build |
Address late feedback from @ahsonkhan on PR #33201