Conversation
|
|
|
Is there more code in the methods that you modified, that hasn't been ported over? This change looks good. |
|
|
||
| using (var connection = new SqlConnection(tcpConnStr)) | ||
| { | ||
| var cmd = new SqlCommand(createTableQuery, connection); |
There was a problem hiding this comment.
using(var cmd = new SqlCommand(createTableQuery, connection) )
| using (var connection = new SqlConnection(tcpConnStr)) | ||
| { | ||
| var dropTableQuery = "DROP TABLE IF EXISTS " + tableName; | ||
| var cmd = new SqlCommand(dropTableQuery, connection); |
There was a problem hiding this comment.
Wrap command in using so that it is disposed ?
| public static void ExecuteNonQueries() | ||
| { | ||
| entities = new List<EventInfo> | ||
| { |
There was a problem hiding this comment.
Nit: Formatting of { seems off.
saurabh500
left a comment
There was a problem hiding this comment.
Some test code needs to be addressed.
|
@saurabh500 there are some calls and checks missing but I don't see them being used or implemented anywhere- for instance regarding inRetry checks or TdsParser.ReliabilitySection. |
|
LGTM |
| private static string tableName = "BatchDemoTable"; | ||
| private static List<EventInfo> entities; | ||
|
|
||
| [Fact] |
There was a problem hiding this comment.
Should this be [CheckConnStrSetupFact] ? The test relies on a server being configured and CI doesn't have the SQL Server configured.
There was a problem hiding this comment.
The error in the CI is System.InvalidOperationException : The ConnectionString property has not been initialized.
This is happening because the Connection String being picked up with environment variables is empty in the CI. The [CheckConnStrSetupFact] should resolve the issue.
The build with this commit is expected to fail as well.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks. Updated the test.
|
@dotnet-bot Test OSX x64 Debug Build please
No test or compilation errors. |
Backport of dotnet#29614 (#368) Fixes mono/mono#14450
Fixed GithubIssue dotnet/corefx#29391 Commit migrated from dotnet/corefx@8e1d7bd
Fixed issue #29391 Exception thrown with updateBatchSize bigger than 1 using SqlDataAdapter.
Edit:
Fixes #29391