This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix TODO to cleanup Tests by removing AsReadOnySpan/Memory and update callsites#28962
Merged
ahsonkhan merged 1 commit intodotnet:masterfrom Apr 10, 2018
Merged
Fix TODO to cleanup Tests by removing AsReadOnySpan/Memory and update callsites#28962ahsonkhan merged 1 commit intodotnet:masterfrom
ahsonkhan merged 1 commit intodotnet:masterfrom
Conversation
Author
|
https://github.com/dotnet/corefx/issues/21037 @dotnet-bot test OSX x64 Debug Build |
ghost
approved these changes
Apr 10, 2018
| } | ||
| var span = new Span<char>(a); | ||
| bool result = span.AsReadOnlySpan().IsWhiteSpace(); | ||
| bool result = ((ReadOnlySpan<char>)span).IsWhiteSpace(); |
Member
There was a problem hiding this comment.
I assume we have IsWhitespace that extends Span directly so people don't have to do this cast. i.e. the cast is for testing purposes only.
Author
There was a problem hiding this comment.
IsWhiteSpace extends ReadOnlySpan<char> only and is not visible on Span<char>. So, if someone has Span<char>, they would need the explicit cast or call the ReadOnlySpan ctor (or rely on a local ReadOnlySpan from the span, using implicit cast).
KrzysztofCwalina
approved these changes
Apr 10, 2018
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
… callsites (dotnet/corefx#28962) Commit migrated from dotnet/corefx@b1be362
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @atsushikan, @KrzysztofCwalina
Fixes leftover work from https://github.com/dotnet/corefx/issues/26894