This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add System.Security.Permissions netfx facade and mark some APIs as obsolet to match desktop#26758
Merged
safern merged 2 commits intodotnet:masterfrom Feb 5, 2018
Merged
Conversation
…solet to match desktop
Member
Author
|
@dotnet-bot test OSX x64 Debug Build please |
ViktorHofer
approved these changes
Feb 2, 2018
weshaggard
reviewed
Feb 2, 2018
| <ProjectGuid>{07CAF142-B259-418E-86EF-C4BD8B50253E}</ProjectGuid> | ||
| <!-- UAPvNext is not yet mapped to netstandard2.0, manually duplicate this ref --> | ||
| <PackageTargetFramework>netstandard2.0;$(UAPvNextTFM)</PackageTargetFramework> | ||
| <PackageTargetFramework Condition="'$(TargetGroup)' == 'netstandard'">netstandard2.0;$(UAPvNextTFM)</PackageTargetFramework> |
Member
There was a problem hiding this comment.
We shouldn't even need this any longer as UAP supports netstandard2.0. IIRC we removed most of these from the repo already.
weshaggard
reviewed
Feb 2, 2018
| </ItemGroup> | ||
| <ItemGroup Condition="'$(TargetGroup)' != 'netfx'"> | ||
| <ProjectReference Include="..\..\System.Security.AccessControl\ref\System.Security.AccessControl.csproj" /> | ||
| <SuppressPackageTargetFrameworkCompatibility Include="$(UAPvNextTFM)" /> |
Member
There was a problem hiding this comment.
This can be removed if you remove the PackageTargetFramework above.
weshaggard
approved these changes
Feb 2, 2018
Member
weshaggard
left a comment
There was a problem hiding this comment.
Looks good other then the one comment.
weshaggard
approved these changes
Feb 5, 2018
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Sep 23, 2019
* Remove IsFastSort optimizations from String - Fix bugs in the Span-based globalization fast paths. Note that some of these bug fixes are going to affect performance of the globalization fast paths. - Use Span-based globalization fast paths for strings - Avoid static array allocation for HighCharTable Fixes dotnet#26758 Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Sep 24, 2019
* Remove IsFastSort optimizations from String - Fix bugs in the Span-based globalization fast paths. Note that some of these bug fixes are going to affect performance of the globalization fast paths. - Use Span-based globalization fast paths for strings - Avoid static array allocation for HighCharTable Fixes dotnet#26758 Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
that referenced
this pull request
Sep 25, 2019
* Remove IsFastSort optimizations from String - Fix bugs in the Span-based globalization fast paths. Note that some of these bug fixes are going to affect performance of the globalization fast paths. - Use Span-based globalization fast paths for strings - Avoid static array allocation for HighCharTable Fixes #26758 Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…solet to match desktop (dotnet/corefx#26758) * Add System.Security.Permissions netfx facade and mark some APIs as obsolet to match desktop * PR Feedback Commit migrated from dotnet/corefx@2ef483f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/dotnet/corefx/issues/24517
cc: @weshaggard @danmosemsft @ViktorHofer