Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Disable the DiagnosticTest on Framework #26645

Merged
stephentoub merged 2 commits intodotnet:masterfrom
saurabh500:26615
Jan 29, 2018
Merged

Disable the DiagnosticTest on Framework #26645
stephentoub merged 2 commits intodotnet:masterfrom
saurabh500:26615

Conversation

@saurabh500
Copy link
Contributor

@saurabh500 saurabh500 commented Jan 29, 2018 •
edited
Loading

The feature is not available on the framework and hence the tests are failing. The failures were probably not being caught before the helix fixes.
Fixes https://github.com/dotnet/corefx/issues/26615

@saurabh500
Copy link
Contributor Author

saurabh500 commented Jan 29, 2018

Verified that the tests pass successfully System.Data.SqlClient.Tests Total: 112, Errors: 0, Failed: 0, Skipped: 1, Time: 17.126s

@saurabh500
Copy link
Contributor Author

saurabh500 commented Jan 29, 2018

Jenkins error

java.io.FileNotFoundException: /jenkins/jobs/dotnet_corefx/jobs/master/jobs/windows-TGroup_all+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/builds/7424/program.dat (No such file or directory)
	at java.io.FileInputStream.open0(Native Method)
	at java.io.FileInputStream.open(FileInputStream.java:195)
	at java.io.FileInputStream.<init>(FileInputStream.java:138)
	at org.jenkinsci.plugins.workflow.support.pickles.serialization.RiverReader.openStreamAt(RiverReader.java:183)
	at org.jenkinsci.plugins.workflow.support.pickles.serialization.RiverReader.restorePickles(RiverReader.java:133)
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.loadProgramAsync(CpsFlowExecution.java:618)
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.onLoad(CpsFlowExecution.java:589)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.onLoad(WorkflowRun.java:613)
	at hudson.model.RunMap.retrieve(RunMap.java:225)
	at hudson.model.RunMap.retrieve(RunMap.java:57)
	at jenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java:500)
	at jenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java:482)
	at jenkins.model.lazy.AbstractLazyLoadRunMap.getByNumber(AbstractLazyLoadRunMap.java:380)
	at jenkins.model.lazy.AbstractLazyLoadRunMap.search(AbstractLazyLoadRunMap.java:345)
	at jenkins.model.lazy.AbstractLazyLoadRunMap.newestBuild(AbstractLazyLoadRunMap.java:275)
	at jenkins.model.lazy.LazyLoadRunMapEntrySet$1.<init>(LazyLoadRunMapEntrySet.java:65)
	at jenkins.model.lazy.LazyLoadRunMapEntrySet.iterator(LazyLoadRunMapEntrySet.java:63)
	at java.util.AbstractMap$2$1.<init>(AbstractMap.java:411)
	at java.util.AbstractMap$2.iterator(AbstractMap.java:410)
	at hudson.util.RunList.iterator(RunList.java:113)
	at com.google.common.collect.Iterables.find(Iterables.java:656)
	at io.jenkins.blueocean.service.embedded.rest.QueueUtil.getRun(QueueUtil.java:41)
	at io.jenkins.blueocean.events.BlueMessageEnricher.enrich(BlueMessageEnricher.java:104)
	at org.jenkinsci.plugins.pubsub.PubsubBus.publish(PubsubBus.java:133)
	at org.jenkinsci.plugins.pubsub.listeners.SyncRunListener.onFinalized(SyncRunListener.java:68)
	at hudson.model.listeners.RunListener.fireFinalized(RunListener.java:257)
	at hudson.model.Run.onEndBuilding(Run.java:1925)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.finish(WorkflowRun.java:683)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.access$1400(WorkflowRun.java:135)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun$GraphL.onNewHead(WorkflowRun.java:967)
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.notifyListeners(CpsFlowExecution.java:1212)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$3.run(CpsThreadGroup.java:407)
	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35)
Caused: java.io.IOException: Failed to load build state
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$3.onSuccess(CpsFlowExecution.java:700)
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$3.onSuccess(CpsFlowExecution.java:696)
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$4$1.run(CpsFlowExecution.java:745)
	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Finished: FAILURE

Test Packaging All Configurations x64 Debug Build please

@saurabh500
Copy link
Contributor Author

saurabh500 commented Jan 29, 2018

@dotnet-bot Test Packaging All Configurations x64 Debug Build please

stephentoub
stephentoub reviewed Jan 29, 2018
View reviewed changes
src/System.Data.SqlClient/tests/FunctionalTests/DiagnosticTest.cs Outdated

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.UapAot)] // Internals reflection not supported on uapaot
[SkipOnTargetFramework(TargetFrameworkMonikers.UapAot | TargetFrameworkMonikers.NetFramework)] // Internals reflection not supported on UapAot
Copy link
Member

@stephentoub stephentoub Jan 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the comment be updated as well for all of these?

@stephentoub
Copy link
Member

stephentoub commented Jan 29, 2018

Merging to unblock other PRs

@stephentoub stephentoub merged commit dfd9d76 into dotnet:master Jan 29, 2018
This was referenced Jan 29, 2018
Merged
Merged
@bartonjs bartonjs mentioned this pull request Jan 29, 2018
Merged
@karelz karelz added this to the 2.1.0 milestone Feb 4, 2018
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@saurabh500 @stephentoub
Disable the DiagnosticTest on Framework (dotnet/corefx#26645)
684879c 
* Disable the DiagnosticTest on Framework because the feature is not available

* Fixing comments


Commit migrated from dotnet/corefx@dfd9d76
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@danmoseley danmoseley Awaiting requested review from danmoseley

2 more reviewers

@stephentoub stephentoub stephentoub approved these changes

@corivera corivera corivera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

NetFX Failing CI for System.Data.SqlClient.Tests

4 participants

@saurabh500 @stephentoub @corivera @karelz