This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Environment.ProcessorCount: use runtime implementation via EnvironmentAugments#25630
Merged
jkotas merged 2 commits intodotnet:masterfrom Dec 5, 2017
Merged
Environment.ProcessorCount: use runtime implementation via EnvironmentAugments#25630jkotas merged 2 commits intodotnet:masterfrom
jkotas merged 2 commits intodotnet:masterfrom
Conversation
stephentoub
approved these changes
Dec 1, 2017
Member
|
You can also delete src\Common\src\Interop\Windows\kernel32\Interop.GetLogicalProcessorInformationEx.cs |
Member
You will also need to add it to CoreRT first - UWP NETNative leg will have this build break without it. |
Member
|
@dotnet-bot test this please |
joperezr
approved these changes
Dec 4, 2017
Member
joperezr
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Member
Author
|
@dotnet-bot test this please |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…tAugments (dotnet/corefx#25630) * Environment.ProcessorCount: use runtime implementation via EnvironmentAugments * Remove Interop.GetLogicalProcessorInformationEx.cs Commit migrated from dotnet/corefx@17be4bc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't build on my machine (yet):
EnvironmentAugments.ProcessorCount was added in dotnet/coreclr#15297.
I've made the change for all platforms (i.e. also Windows) and removed the corefx implementation.
CC @stephentoub @jkotas