This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Microsoft.CSharp: Remove check for ExprMemberGroup being used as a lvalue#25214
Merged
VSadov merged 2 commits intodotnet:masterfrom Nov 15, 2017
Merged
Microsoft.CSharp: Remove check for ExprMemberGroup being used as a lvalue#25214VSadov merged 2 commits intodotnet:masterfrom
VSadov merged 2 commits intodotnet:masterfrom
Conversation
ExprMemberGroups only exist within ExprCall objects and can never be passed as operands, so this is unreachable. (Unlike in static compilation where it would be the result of someone trying e.g. obj.ToString = 3). Entails removal of ERR_AssgReadonlyLocalCause, contributes to #22470
Only place it was instantiated has now been removed. Clean-up all unused ErrArgKind as well as Ids that this makes unused.
Contributor
Author
|
Test Windows x86 Release Build Failure in PerformanceCounter_IncrementBy_IncrementByReadOnly https://mc.dot.net/#/user/JonHanna/pr~2Fjenkins~2Fdotnet~2Fcorefx~2Fmaster~2F/test~2Ffunctional~2Fcli~2F/5cb7cb031ae3f872881b8d30f82f1df178ff8507/workItem/System.Diagnostics.PerformanceCounter.Tests |
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Jul 15, 2019
…rvices (dotnet#25214) * Address nullable feedback for System.Threading.Overlapped * Address nullable feedback for System.Memory * Address nullable for System.Runtime.InteropServices * Update xml comments and make CultureInfo nullable to match String.ToLower/Upper feedback * PR feedback: revert accepting null comparer in BinarySearch * Disable test that needs to be updated in corefx Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
that referenced
this pull request
Jul 15, 2019
…rvices (#25214) * Address nullable feedback for System.Threading.Overlapped * Address nullable feedback for System.Memory * Address nullable for System.Runtime.InteropServices * Update xml comments and make CultureInfo nullable to match String.ToLower/Upper feedback * PR feedback: revert accepting null comparer in BinarySearch * Disable test that needs to be updated in corefx Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…alue (dotnet/corefx#25214) * Remove check for ExprMemberGroup being used as a lvalue. ExprMemberGroups only exist within ExprCall objects and can never be passed as operands, so this is unreachable. (Unlike in static compilation where it would be the result of someone trying e.g. obj.ToString = 3). Entails removal of ERR_AssgReadonlyLocalCause, contributes to dotnet/corefx#22470 * Remove ErrArgIds class Only place it was instantiated has now been removed. Clean-up all unused ErrArgKind as well as Ids that this makes unused. Commit migrated from dotnet/corefx@fff6031
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExprMemberGroups only exist withinExprCallandExprPropertyobjects and can never be passed as operands, so this is unreachable. (Unlike in static compilation where it would be the result of someone trying e.g.obj.ToString = 3).Results in removal of ERR_AssgReadonlyLocalCause, contributes to #22470.
ErrArgIdsclassOnly place it was instantiated has now been removed.
Clean-up all unused
ErrArgKindas well asIdsthat this makes unused.