This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Moving CompileDeepTree_NoStackOverflowFast to the outer loop#19563
Merged
stephentoub merged 1 commit intodotnet:masterfrom May 9, 2017
Merged
Moving CompileDeepTree_NoStackOverflowFast to the outer loop#19563stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
It appears that the test equally stresses the Expression Tree Compiler and the JIT compiler. Normally this is not a problem since JIT compiler uses much less resources that ET compiler and 128Kb of stack is more than enough to JIT the resulting method. That does not seem to be the case when running on Debug and the test may fail on debug runtime/JIT We generally want the inner loop to pass on Debug though, so the test should be moved to the outer loop.
Member
Author
OmarTawfik
approved these changes
May 9, 2017
stephentoub
approved these changes
May 9, 2017
Member
Author
|
CC: @jaredpar |
Contributor
|
It may as well be deleted in this case. Its purpose is to be a quicker version of an outerloop test so that while not as thorough, it need not be outerloop. |
Member
Author
|
@JonHanna - I have decided to keep it - since it is cheap. |
|
@VSadov , Thank you! |
jakobbotsch
added a commit
to jakobbotsch/runtime
that referenced
this pull request
May 27, 2021
The manually assigned 128 KiB stack here is bordering on the amount of stack space that release JIT needs to JIT functions with deep trees. Since the JIT already has a limit on the depth of trees it creates https://github.com/dotnet/runtime/blob/44f050acc0f7791d6cd7ac772945444912bcf299/src/coreclr/jit/importer.cpp#L11234-L11252 it seems unnecessary to pressimize the JIT further to allow this test to pass. Also, the test was originally added as a faster equivalent to the test above it that could run in inner loop (dotnet/corefx#14444), but it was subsequently moved to outer loop (dotnet/corefx#19563), so now it does not seem like there's much point in retaining it. Fix dotnet#53309
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that the test equally stresses the Expression Tree Compiler and the JIT compiler.
Normally this is not a problem since JIT compiler uses much less resources that ET compiler and 128Kb of stack is more than enough to JIT the resulting method.
That does not seem to be the case when running on Debug and the test may fail on debug runtime/JIT
We generally want the inner loop to pass on Debug though, so the test should be moved to the outer loop.
Fixes:#18966