Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Switch to use CoreLib Path class.#13920

Merged
JeremyKuhne merged 1 commit intodotnet:masterfrom
JeremyKuhne:usecorepath
Dec 10, 2016
Merged

Switch to use CoreLib Path class.#13920
JeremyKuhne merged 1 commit intodotnet:masterfrom
JeremyKuhne:usecorepath

Conversation

@JeremyKuhne
Copy link
Member

Leaving the code for UAP for now- we may end up needing to keep it.
(Notably for the Crypto)

@ianhays

{24BCEC6B-B9D2-47BC-9D66-725BD6B526FA}.net46_Debug|Any CPU.Build.0 = net46_Debug|Any CPU
{24BCEC6B-B9D2-47BC-9D66-725BD6B526FA}.net46_Release|Any CPU.ActiveCfg = net46_Release|Any CPU
{24BCEC6B-B9D2-47BC-9D66-725BD6B526FA}.net46_Release|Any CPU.Build.0 = net46_Release|Any CPU
{24BCEC6B-B9D2-47BC-9D66-725BD6B526FA}.netstandard1.7_Debug|Any CPU.ActiveCfg = Debug|Any CPU
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all this sln junk?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need, no. Didn't see a point in not including it since these project entries were missing. :)

@JeremyKuhne
Copy link
Member Author

Hitting an issue with the Environment variables being cached on Unix. Investigating.

Leaving the code for UAP for now- we may end up needing to keep it.
(Notably for the Crypto)

Use the core environment variable code.
@JeremyKuhne
Copy link
Member Author

@dotnet-bot test Innerloop OSX Release Build and Test

@JeremyKuhne JeremyKuhne merged commit 227c654 into dotnet:master Dec 10, 2016
@JeremyKuhne JeremyKuhne deleted the usecorepath branch December 10, 2016 04:36
steveharter pushed a commit to steveharter/dotnet_corefx that referenced this pull request Dec 19, 2016
Leaving the code for UAP for now- we may end up needing to keep it.
(Notably for the Crypto)

Use the core environment variable code.
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Leaving the code for UAP for now- we may end up needing to keep it.
(Notably for the Crypto)

Use the core environment variable code.

Commit migrated from dotnet/corefx@227c654
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants