Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Synchronize src\mscorlib\corefx with CoreRT#9251

Merged
jkotas merged 1 commit intodotnet:masterfrom
jkotas:corert
Feb 1, 2017
Merged

Synchronize src\mscorlib\corefx with CoreRT#9251
jkotas merged 1 commit intodotnet:masterfrom
jkotas:corert

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Feb 1, 2017

No description provided.

if (info == null)
{
throw new ArgumentNullException(nameof(info));
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this removal intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - the base class does the validation already. Some exceptions types used to have the redundant validation here, some did not. I have done pass in CoreRT to strip it from all of them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@jkotas jkotas merged commit 76e174f into dotnet:master Feb 1, 2017
@jkotas jkotas deleted the corert branch February 4, 2017 04:23
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants