This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Enable thread interrupt in finally blocks, remove some invalid asserts#8953
Merged
jkotas merged 2 commits intodotnet:masterfrom Jan 14, 2017
kouvel:InterruptInFinally
Merged
Enable thread interrupt in finally blocks, remove some invalid asserts#8953jkotas merged 2 commits intodotnet:masterfrom kouvel:InterruptInFinally
jkotas merged 2 commits intodotnet:masterfrom
kouvel:InterruptInFinally
Conversation
added 2 commits
January 13, 2017 17:21
Thread abort was not allowed in finally blocks, but the same logic was being applied to thread interrupt as well. There is nothing special about thread interrupt that requires it to not work in finally blocks.
These cases are actually possible because Windows APIs are inconsistent in their behavior when invalid handles are concerned. Depending on the invalid handle's value, a multi-wait can error with ERROR_INVALID_HANDLE, and a single-wait on an invalid handle could return WAIT_TIMEOUT.
Author
Author
|
Relevant to issue #8924 |
jkotas
approved these changes
Jan 14, 2017
Member
|
@dotnet-bot test Windows_NT x64 Release Priority 1 Build and Test please |
kouvel
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 17, 2017
Add tests for thread interrupt in finally blocks Related to dotnet/coreclr#8953
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Enable thread interrupt in finally blocks, remove some invalid asserts Commit migrated from dotnet/coreclr@496c33f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit descriptions