This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Reduce SeekUnroll iter count#8861
Merged
michellemcdaniel merged 1 commit intodotnet:masterfrom Jan 10, 2017
Merged
Conversation
Author
|
@JosephTremoulet PTAL |
Author
|
Fixes #8838 |
JosephTremoulet
approved these changes
Jan 10, 2017
JosephTremoulet
left a comment
There was a problem hiding this comment.
LGTM modulo a couple nits/questions, thanks.
| [assembly: MeasureInstructionsRetired] | ||
|
|
||
| public static class SeekUnroll | ||
| public class SeekUnroll |
There was a problem hiding this comment.
Nit: This bit seems unnecessary since you've made the field static
| { | ||
| int failures = 0; | ||
| if (!Vector.IsHardwareAccelerated) | ||
| { |
There was a problem hiding this comment.
- Might want to add a comment explaining this.
- Have you verified that this fixes the problem when run through the test harness? It just now occurred to me that maybe
Maindoesn't execute when xunit-perf runs the test? (also, I'm not sure if our CI is running this through xunit-perf or not... presumably if we do want to track the performance of this test on a non-accelerated platform we'd want some value between 1 and 100000000...)
Author
There was a problem hiding this comment.
I added a comment and upped the value to 100000. We can up it again later if we need/want to. I've tested this inside runtest.cmd, and it runs successfully.
027d389 to
ff644f7
Compare
On non-hardware accelerated platforms, reduce the inner iteration count in SeekUnroll. This test was timing out in x86 release builds because the iteration count was too high.
ff644f7 to
2c866c5
Compare
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Reduce SeekUnroll iter count Commit migrated from dotnet/coreclr@7dd3478
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On non-hardware accelerated platforms, reduce the inner iteration count in
SeekUnroll. This test was timing out in x86 release builds because the
iteration count was too high.