This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Skip removed loops in optBlockIsLoopEntry#7909
Merged
JosephTremoulet merged 1 commit intodotnet:masterfrom Nov 1, 2016
Merged
Conversation
This allows running this utility downstream of loop unrolling.
Author
|
@dotnet/jit-contrib PTAL. |
|
LGTM |
1 similar comment
|
LGTM |
AndyAyersMS
added a commit
to AndyAyersMS/coreclr
that referenced
this pull request
Feb 13, 2017
The jit relies on a particular tree remaining intact during importation to optimize type equality tests commonly found in generics. In dotnet#7909 the jit started aggressively spilling the evaluation stack before calls, which broke up the trees needed for the optimizations. In the special cases pertaining to type tests the trees can safely remain intact because we know the calls can't interact with the computations on the stack. Recognize these cases and selectively suppress spilling. Closes #9552.
jorive
pushed a commit
to guhuro/coreclr
that referenced
this pull request
May 4, 2017
The jit relies on a particular tree remaining intact during importation to optimize type equality tests commonly found in generics. In dotnet#7909 the jit started aggressively spilling the evaluation stack before calls, which broke up the trees needed for the optimizations. In the special cases pertaining to type tests the trees can safely remain intact because we know the calls can't interact with the computations on the stack. Recognize these cases and selectively suppress spilling. Closes #9552.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
The jit relies on a particular tree remaining intact during importation to optimize type equality tests commonly found in generics. In dotnet/coreclr#7909 the jit started aggressively spilling the evaluation stack before calls, which broke up the trees needed for the optimizations. In the special cases pertaining to type tests the trees can safely remain intact because we know the calls can't interact with the computations on the stack. Recognize these cases and selectively suppress spilling. Closes dotnet/coreclr#9552. Commit migrated from dotnet/coreclr@a26e2c6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows running this utility downstream of loop unrolling.