This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Do not create diagnostics server thread and pipe if EnableDiagnostics is set to 0#27137
Merged
sywhang merged 2 commits intodotnet:masterfrom Oct 11, 2019
Merged
Do not create diagnostics server thread and pipe if EnableDiagnostics is set to 0#27137sywhang merged 2 commits intodotnet:masterfrom
sywhang merged 2 commits intodotnet:masterfrom
Conversation
jkotas
reviewed
Oct 11, 2019
hoyosjs
approved these changes
Oct 11, 2019
sywhang
added a commit
to sywhang/coreclr
that referenced
this pull request
Oct 11, 2019
… is set to 0 (dotnet#27137) * Do not create diagnostics server thread and pipe if EnableDiagnostics is set to 0 * Remove unnecessary check for config var in DiagnosticServer::Shutdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have the environment variable
COMPlus_EnableDiagnosticsthat disables the debugger when it is set to 0. We should disable diagnostics server as well if this environment variable is set to 0.This fixes https://github.com/dotnet/coreclr/issues/27134.