This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove unnecessary cleanup on diagnostics server thread during shutdown#27136
Merged
jkotas merged 2 commits intodotnet:masterfrom Oct 11, 2019
Merged
Remove unnecessary cleanup on diagnostics server thread during shutdown#27136jkotas merged 2 commits intodotnet:masterfrom
jkotas merged 2 commits intodotnet:masterfrom
Conversation
noahfalk
suggested changes
Oct 11, 2019
josalem
approved these changes
Oct 11, 2019
josalem
left a comment
There was a problem hiding this comment.
LGTM. Let's circle back and add an envvar or similar mechanism for disabling the Diagnostics Server as well.
Author
Here: #27137 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During shutdown, we are doing unnecessary cleanup of the process by cleaning up threads, etc when this could be done by the OS with the process exit.
This should fix https://github.com/dotnet/coreclr/issues/27128.
cc @jkotas