This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Perf improvements to char.IsWhiteSpace / char.IsUpper / char.IsLower#26848
Merged
GrabYourPitchforks merged 3 commits intodotnet:masterfrom Sep 24, 2019
Merged
Perf improvements to char.IsWhiteSpace / char.IsUpper / char.IsLower#26848GrabYourPitchforks merged 3 commits intodotnet:masterfrom
GrabYourPitchforks merged 3 commits intodotnet:masterfrom
Conversation
Member
|
This PR also was supposed to remove |
tarekgh
approved these changes
Sep 24, 2019
Member
Author
|
Unit tests at dotnet/corefx#41265. |
marek-safar
reviewed
Sep 24, 2019
marek-safar
reviewed
Sep 24, 2019
marek-safar
reviewed
Sep 24, 2019
adamsitnik
approved these changes
Sep 24, 2019
Member
adamsitnik
left a comment
There was a problem hiding this comment.
Looks great to me!
@GrabYourPitchforks could you please contribute your benchmarks to https://github.com/dotnet/performance/blob/master/src/benchmarks/micro/corefx/System.Runtime/Perf.Char.cs?
No functional changes
Member
Author
|
CI failures are unrelated. Marching forward with submission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is especially noticeable in benchmarks for APIs like
ReadOnlySpan.Trim().Benchmark code:
The performance should improve even further when https://github.com/dotnet/coreclr/issues/26845 is fixed.