This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Save corefx test build artifacts to unique folder#26466
Merged
BruceForstall merged 3 commits intodotnet:masterfrom Sep 1, 2019
Merged
Save corefx test build artifacts to unique folder#26466BruceForstall merged 3 commits intodotnet:masterfrom
BruceForstall merged 3 commits intodotnet:masterfrom
Conversation
It would be better to also include the `r2r` and `corefx` tags in the archive filename, for clarity, but that is a bigger change and not necessary to fix the current failing jobs due to the existing name conflict.
Author
|
@trylek PTAL |
jashook
reviewed
Aug 31, 2019
eng/xplat-test-job.yml
Outdated
| value: $(binTestsPath)/$(osGroup).$(archType).$(buildConfigUpper) | ||
|
|
||
| - ${{ if ne(parameters.readyToRun, true) }}: | ||
| ${{ if and(eq(parameters.corefxTests, true), eq(parameters.readyToRun, true)) }}: |
There was a problem hiding this comment.
Missing -, see https://github.com/BruceForstall/coreclr/pull/1/files
Author
|
Now, and Correspondingly, and |
trylek
reviewed
Sep 1, 2019
Member
trylek
left a comment
There was a problem hiding this comment.
Thanks for fixing this and apologies about my overlooking in the first place!
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Save corefx test build artifacts to unique folder It would be better to also include the `r2r` and `corefx` tags in the archive filename, for clarity, but that is a bigger change and not necessary to fix the current failing jobs due to the existing name conflict. * Add - Commit migrated from dotnet/coreclr@89db551
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be better to also include the
r2randcorefxtagsin the archive filename, for clarity, but that is a bigger change
and not necessary to fix the current failing jobs due to the
existing name conflict.
Fixes a problem identified in #26392