This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Make sure we use a 64 bit number to represent memory limit (even in 32 bit architectures)#25724
Merged
cshung merged 1 commit intodotnet:masterfrom Jul 18, 2019
Merged
Conversation
janvorli
reviewed
Jul 16, 2019
Member
janvorli
left a comment
There was a problem hiding this comment.
Can you please make the same change to the src/pal/src/misc/cgroup.cpp too? It is the same code, but used by the runtime and the embedded GC.
f4d8af1 to
2fb9feb
Compare
…2 bit architectures)
2fb9feb to
170b6e4
Compare
Author
|
@janvorli Can you please take a look? I don't believe the test failure has to do with my change. |
janvorli
approved these changes
Jul 18, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…2 bit architectures) (dotnet/coreclr#25724) Commit migrated from dotnet/coreclr@a1e1fa3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR was originally developed from https://github.com/dotnet/corert/pull/7620/files for issue dotnet/corert#7619