Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix a build error when IBCLOGGER_ENABLED is not defined#25691

Merged
jkotas merged 1 commit intodotnet:masterfrom
clamp03:ibc
Jul 17, 2019
Merged

Fix a build error when IBCLOGGER_ENABLED is not defined#25691
jkotas merged 1 commit intodotnet:masterfrom
clamp03:ibc

Conversation

@clamp03
Copy link
Member

@clamp03 clamp03 commented Jul 15, 2019

  • Even if DACCESS_COMPILE or CROSSGEN_COMPILE is defined,
    coreclr can be built without IBCLOGGER_ENABLED definition.

- Even if DACCESS_COMPILE or CROSSGEN_COMPILE is defined,
  coreclr can be built without IBCLOGGER_ENABLED definition.
@dnfclas
Copy link

dnfclas commented Jul 15, 2019

CLA assistant check
All CLA requirements met.

@clamp03
Copy link
Member Author

clamp03 commented Jul 15, 2019

@jkotas and @alpencolt Hello, could you please review?

This patch fixes a build error when I disabled IBCLOGGER_ENABLED only.
When IBCLOGGER_ENABLED is not defined, it improves startup time about 1.7% in my experiment.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 7e416e3 into dotnet:master Jul 17, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…lr#25691)

- Even if DACCESS_COMPILE or CROSSGEN_COMPILE is defined,
  coreclr can be built without IBCLOGGER_ENABLED definition.

Commit migrated from dotnet/coreclr@7e416e3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants