This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Reverting the ShouldRoundUp logic to not change for custom numeric format strings.#25400
Merged
tannergooding merged 1 commit intodotnet:masterfrom Jun 26, 2019
tannergooding:fix-custom-format
Merged
Reverting the ShouldRoundUp logic to not change for custom numeric format strings.#25400tannergooding merged 1 commit intodotnet:masterfrom tannergooding:fix-custom-format
tannergooding merged 1 commit intodotnet:masterfrom
tannergooding:fix-custom-format
Conversation
Member
Author
Member
Author
|
Tests are here, they haven't yet been merged from yesterdays PR: dotnet/corefx#38627 Working with @mjsabby to ensure the proper regression tests are added. |
GrabYourPitchforks
approved these changes
Jun 26, 2019
tannergooding
added a commit
to dotnet/corefx
that referenced
this pull request
Jul 2, 2019
* Add a number of new RealFormatter tests * Fixing up some custom formatter tests in response to dotnet/coreclr#25400 * Don't run the custom numeric format tests against the UTF8Formatter
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…rmat strings. (dotnet/coreclr#25400) Commit migrated from dotnet/coreclr@d9d31e6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was pinged by @mjsabby from Bing that a change from e3c9a4a was impacting them.
This ensures that custom-numeric format strings have the same behavior as previous for .NET Core 3.0. Post 3.0, this likely needs further thought so that for format strings in general (both standard and custom) users can get spec compliant or the desired behavior. This would likely involve exposing some API that takes a
MidpointRoundingModeenum so that it can be controlled as appropriate.