Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix visibility on Exception.InnerExceptionPrefix#25278

Merged
jkotas merged 1 commit intomasterfrom
stephentoub-exceptionvis
Jun 20, 2019
Merged

Fix visibility on Exception.InnerExceptionPrefix#25278
jkotas merged 1 commit intomasterfrom
stephentoub-exceptionvis

Conversation

@stephentoub
Copy link
Member

cc: @danmosemsft, @jkotas

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I guess I did not properly know the difference between these.

@stephentoub
Copy link
Member Author

I did not properly know the difference between these.

It's confusing that internal protected means internal || protected rather than internal && protected. private protected was only recently introduced to mean the latter.

@danmoseley
Copy link
Member

Ah I see, thanks. Confusing indeed

@jkotas jkotas merged commit 8676608 into master Jun 20, 2019
pull bot pushed a commit to HarrievG/coreclr that referenced this pull request Jun 20, 2019
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Jun 20, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/mono that referenced this pull request Jun 20, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas pushed a commit to dotnet/corert that referenced this pull request Jun 20, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
marek-safar pushed a commit to mono/mono that referenced this pull request Jun 21, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
@jkotas jkotas deleted the stephentoub-exceptionvis branch June 22, 2019 06:31
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corefx that referenced this pull request Jul 15, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub added a commit to dotnet/corefx that referenced this pull request Jul 15, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants