This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Merged
Conversation
danmoseley
approved these changes
Jun 20, 2019
Member
danmoseley
left a comment
There was a problem hiding this comment.
Thanks @janvorli. CI was clean...is this in some kind of outerloop that I should have run?
Member
|
Test like this belongs to CoreFX. I have added coverage for this case in dotnet/corefx#38724. Could you please delete this test here instead? |
Member
Author
|
@danmosemsft yes, this is a Pri 1 test. |
This test was checking for "Parameter name:" substring in the ArgumentNullException message. But a recent change dotnet#25185 modified that string to just "Parameter". We also have a coverage for this in corefx tests, so I am removing this test.
1683565 to
361d8d1
Compare
Member
Author
|
@jkotas ok, I've deleted it instead. |
jkotas
approved these changes
Jun 20, 2019
pull bot
pushed a commit
to HarrievG/coreclr
that referenced
this pull request
Jun 20, 2019
This test was checking for "Parameter name:" substring in the ArgumentNullException message. But a recent change dotnet#25185 modified that string to just "Parameter". We also have a coverage for this in corefx tests, so I am removing this test.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This test was checking for "Parameter name:" substring in the ArgumentNullException message. But a recent change dotnet/coreclr#25185 modified that string to just "Parameter". We also have a coverage for this in corefx tests, so I am removing this test. Commit migrated from dotnet/coreclr@b1ea5ed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was checking for "Parameter name:" substring in the
ArgumentNullException message. But a recent change #25185 modified
that string to just "Parameter".
We also have a coverage for this in corefx tests, so I am removing this test.
Close #25271