This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Make Idn.GetAscii compatible with Windows#24443
Merged
tarekgh merged 1 commit intodotnet:masterfrom May 7, 2019
Merged
Conversation
GetAscii on Windows ignore if the uri has hyphens in the third and fourth places. We relaxing this on Linux too for the sake of the consistent behavior. This issue was causing some problems with the http stack.
stephentoub
reviewed
May 7, 2019
| int32_t asciiStrLen = uidna_nameToASCII(pIdna, lpSrc, cwSrcLength, lpDst, cwDstLength, &info, &err); | ||
|
|
||
| // To have a consistent behavior with Windows, we mask out the error when having 2 hyphens in the third and fourth place. | ||
| info.errors &= ~UIDNA_ERROR_HYPHEN_3_4; |
stephentoub
approved these changes
May 7, 2019
Member
Author
|
The failures looks Helix specific and opened a tracking issue https://github.com/dotnet/coreclr/issues/24453 |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
GetAscii on Windows ignore if the uri has hyphens in the third and fourth places. We relaxing this on Linux too for the sake of the consistent behavior. This issue was causing some problems with the http stack. Commit migrated from dotnet/coreclr@8b6a69e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetAscii on Windows ignore if the uri has hyphens in the third and fourth places. We relaxing this on Linux too for the sake of the consistent behavior. This issue was causing some problems with the http stack.
Fixes https://github.com/dotnet/corefx/issues/29703