This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Implement String.IsAscii in shared CoreLib and use it for [Is]Normalize[d] for all runtimes#24373
Merged
jkotas merged 1 commit intodotnet:masterfrom May 3, 2019
Merged
Conversation
…ze[d] for all runtimes
EgorBo
reviewed
May 3, 2019
| else { | ||
| FC_GC_POLL_NOT_NEEDED(); | ||
| } | ||
| FC_RETURN_BOOL(IS_ASCII(state)); //This can indicate either high chars or special sorting chars. |
Member
There was a problem hiding this comment.
I guess IS_ASCII can be removed as well
Lines 1044 to 1046 in b271aff
EgorBo
reviewed
May 3, 2019
| @@ -64,9 +64,6 @@ public extern int Length | |||
| // and not a - or ' | |||
| [MethodImplAttribute(MethodImplOptions.InternalCall)] | |||
| internal extern bool IsFastSort(); | |||
Member
There was a problem hiding this comment.
IsFastSort internal call should be removed as well if I understand it correctly.
Also I guess we can now remove that code that keeps String state, e.g. remove InternalCheckHighChars etc
Member
There was a problem hiding this comment.
IsFastSort is still used in few places. Cleaning those up can be separate PR.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…ze[d] for all runtimes (dotnet/coreclr#24373) Commit migrated from dotnet/coreclr@0e15f47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on discussion at dotnet/corefx#37358 (comment).