This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Disable loading IJW assemblies into collectible ALC#23430
Merged
janvorli merged 2 commits intodotnet:masterfrom Mar 25, 2019
Merged
Disable loading IJW assemblies into collectible ALC#23430janvorli merged 2 commits intodotnet:masterfrom
janvorli merged 2 commits intodotnet:masterfrom
Conversation
Member
Author
|
@dotnet-bot test Windows_NT arm Cross Checked Innerloop Build and Test please |
Member
Author
|
@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test please |
jkotas
approved these changes
Mar 25, 2019
Member
jkoritzinsky
approved these changes
Mar 25, 2019
Member
jkoritzinsky
left a comment
There was a problem hiding this comment.
There are a few more IJW tests now so make sure to mark them UnloadabilityIncompatible as well. Other than that LGTM!
There were couple of IJW tests added since the master I've based my changes on. Adding disabling of those for unloadability testing.
6032357 to
8fede4d
Compare
Member
Author
|
@jkoritzinsky thanks for the info on the new tests, I've added a commit to disabled them. |
CarolEidt
added a commit
to CarolEidt/coreclr
that referenced
this pull request
Mar 29, 2019
For the Fma case (dotnet#23430), fix the handling of contained 3-operand HW intrinsic nodes. For the Bmi case (#23534), fix a bad assert placement, and re-enable the Bmi tests. Fix #23530 Fix #23534
CarolEidt
added a commit
that referenced
this pull request
Mar 29, 2019
* Fix HW intrinsic containment bugs For the Fma case (#23430), fix the handling of contained 3-operand HW intrinsic nodes. For the Bmi case (#23534), fix a bad assert placement, and re-enable the Bmi tests. Fix #23530 Fix #23534 * Add guard for Fma test
buyaa-n
pushed a commit
to buyaa-n/coreclr
that referenced
this pull request
Apr 1, 2019
* Fix HW intrinsic containment bugs For the Fma case (dotnet#23430), fix the handling of contained 3-operand HW intrinsic nodes. For the Bmi case (#23534), fix a bad assert placement, and re-enable the Bmi tests. Fix #23530 Fix #23534 * Add guard for Fma test
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…d-in-collectible-alc Disable loading IJW assemblies into collectible ALC Commit migrated from dotnet/coreclr@2520798
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Fix HW intrinsic containment bugs For the Fma case (dotnet/coreclr#23430), fix the handling of contained 3-operand HW intrinsic nodes. For the Bmi case (dotnet/coreclr#23534), fix a bad assert placement, and re-enable the Bmi tests. Fix dotnet/coreclr#23530 Fix dotnet/coreclr#23534 * Add guard for Fma test Commit migrated from dotnet/coreclr@1df87c7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IJW (mixed assemblies) have many potential issues with unloadability. They can run arbitrary native code that the runtime knows nothing about, they can have data structures that the runtime knows nothing about etc. So attempt to unload them could easily result in memory leaks and crashes.
This change disables loading IJW assemblies into collectible ALC. These assemblies are supported in .NET Core to simplify migration of an pre-existing code, so we won't support loading them as collectible.
Close #20177