This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix handling of struct setup assignments #23141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In dotnet#22791 I was creating struct assignments with COMMAs on the rhs, but that isn't handled downstream. Fix #23059
Author
|
test OSX10.12 x64 Checked Innerloop Build and Test |
Author
|
@dotnet-bot test Windows_NT x64_Checked jitx86hwintrinsicnosimd |
Author
|
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnosimd |
Author
|
@dotnet/jit-contrib PTAL |
Author
|
@dotnet-bot test Ubuntu x64 Checked CoreFX Tests |
jashook
approved these changes
Mar 11, 2019
Author
|
The Ubuntu x64 Checked CoreFX Tests reported zero test failures but apparently didn't report success. I'm going to ignore that failure. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix handling of struct setup assignments Commit migrated from dotnet/coreclr@9dcbb47
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #22791 I was creating struct assignments with COMMAs on the rhs, but that isn't handled downstream.
Fix #23059