This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Updating runtest.py so that it works with Python 3#19768
Merged
tannergooding merged 1 commit intodotnet:masterfrom Aug 31, 2018
tannergooding:runtest-python3
Merged
Updating runtest.py so that it works with Python 3#19768tannergooding merged 1 commit intodotnet:masterfrom tannergooding:runtest-python3
tannergooding merged 1 commit intodotnet:masterfrom
tannergooding:runtest-python3
Conversation
Member
Author
|
CC. @jashook |
tannergooding
commented
Aug 30, 2018
tests/runtest.py
Outdated
| if host_os != "Windows_NT": | ||
| # Set executable bit | ||
| os.chmod(os.path.join(dest, item), 0774) | ||
| os.chmod(os.path.join(dest, item), 774) |
Member
Author
There was a problem hiding this comment.
This is the only line that doesn't modify a print call
tannergooding
commented
Aug 30, 2018
Member
Author
|
The rest of the changes were |
jashook
approved these changes
Aug 30, 2018
tests/runtest.py
Outdated
|
|
||
| def print_summary(tests): | ||
| """ Print a summary of the test results | ||
| """ print(a summary of the test results |
Member
Author
|
@jashook, there were a couple things I missed, and then I remembered "2to3.py" existed, so I just ran the script through that instead. Validated locally that python3.7 and python2.7 both work as expected. |
tannergooding
commented
Aug 30, 2018
| # Convert self.env to a defaultdict | ||
| self.env = defaultdict(lambda: None, self.env) | ||
| for key, value in env.iteritems(): | ||
| for key, value in env.items(): |
Member
Author
There was a problem hiding this comment.
Python3 removed iteritem
tannergooding
commented
Aug 30, 2018
| print contents | ||
| print() |
Member
Author
There was a problem hiding this comment.
python3 won't complain about just print, but does require print() for it work as intended
Member
Author
|
All the changes required to support Python3 should be documented as part of the 3.0 release notes here: https://docs.python.org/3.0/whatsnew/3.0.html |
jashook
approved these changes
Aug 30, 2018
Member
Author
|
test Windows_NT arm64 Cross Debug Innerloop Build please |
echesakov
added a commit
that referenced
this pull request
Oct 24, 2018
…lix queue Port (partially) the following changes: * Build xunit wrappers the same way on windows and unix (#18695) * Update vc-runtime package to support ARM and ARM64 with current builds (#19265) * build-test - fix TestWrapper CS warnings (#19180) * Clean up build.cmd/build-test.cmd/runtest.cmd (#19291) * Use runtest.py to run tests for all platforms (#19213) * Updating runtest.py so that it works with Python 3 (#19768) * Fix build-test.sh wrapper build (#19779) * Move ARM64 Windows boxen to be Helix-provisioned (#20204) * Runtest.py on Windows Arm(64) (#20227) * Use runtest.cmd for arm(64) windows testing (#20301) * Do not restore or initialize buildtools for x86/arm64 (#20370) * Add hack for arm64/x86 to skip build tools restore (#20390) Update Xunit to 2.4.1 prerelease version Use the latest version (dbf0bf1) of tests/runtest.py
echesakov
added a commit
that referenced
this pull request
Oct 24, 2018
…lix queue Port (partially) the following changes: * Build xunit wrappers the same way on windows and unix (#18695) * Work around cmd command length limit in xunit Exec task (#19095) * Update vc-runtime package to support ARM and ARM64 with current builds (#19265) * build-test - fix TestWrapper CS warnings (#19180) * Clean up build.cmd/build-test.cmd/runtest.cmd (#19291) * Use runtest.py to run tests for all platforms (#19213) * Updating runtest.py so that it works with Python 3 (#19768) * Fix build-test.sh wrapper build (#19779) * Move ARM64 Windows boxen to be Helix-provisioned (#20204) * Runtest.py on Windows Arm(64) (#20227) * Use runtest.cmd for arm(64) windows testing (#20301) * Do not restore or initialize buildtools for x86/arm64 (#20370) * Add hack for arm64/x86 to skip build tools restore (#20390) Update Xunit to 2.4.1 prerelease version Use the latest version (dbf0bf1) of tests/runtest.py
echesakov
added a commit
that referenced
this pull request
Oct 25, 2018
…lix queue Port (partially) the following changes: * Build xunit wrappers the same way on windows and unix (#18695) * Work around cmd command length limit in xunit Exec task (#19095) * Update vc-runtime package to support ARM and ARM64 with current builds (#19265) * build-test - fix TestWrapper CS warnings (#19180) * Clean up build.cmd/build-test.cmd/runtest.cmd (#19291) * Use runtest.py to run tests for all platforms (#19213) * Updating runtest.py so that it works with Python 3 (#19768) * Fix build-test.sh wrapper build (#19779) * Move ARM64 Windows boxen to be Helix-provisioned (#20204) * Runtest.py on Windows Arm(64) (#20227) * Use runtest.cmd for arm(64) windows testing (#20301) * Do not restore or initialize buildtools for x86/arm64 (#20370) * Add hack for arm64/x86 to skip build tools restore (#20390) Update Xunit to 2.4.1 prerelease version Use the latest version (dbf0bf1) of tests/runtest.py
echesakov
added a commit
that referenced
this pull request
Oct 26, 2018
…lix queue Port (partially) the following changes: * Build xunit wrappers the same way on windows and unix (#18695) * Work around cmd command length limit in xunit Exec task (#19095) * Update vc-runtime package to support ARM and ARM64 with current builds (#19265) * build-test - fix TestWrapper CS warnings (#19180) * Clean up build.cmd/build-test.cmd/runtest.cmd (#19291) * Use runtest.py to run tests for all platforms (#19213) * Updating runtest.py so that it works with Python 3 (#19768) * Fix build-test.sh wrapper build (#19779) * Move ARM64 Windows boxen to be Helix-provisioned (#20204) * Runtest.py on Windows Arm(64) (#20227) * Use runtest.cmd for arm(64) windows testing (#20301) * Do not restore or initialize buildtools for x86/arm64 (#20370) * Add hack for arm64/x86 to skip build tools restore (#20390) Update Xunit to 2.4.1 prerelease version Use the latest version (dbf0bf1) of tests/runtest.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#19213 updated runtest.cmd to start calling runtest.py on Windows. For users which only have python 3 installed, this broke the ability to run tests.
This updates the runtest.py file so that it works under Python 3.