This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add public implementation CultureDataSupport#18691
Merged
luqunl merged 2 commits intodotnet:masterfrom Jun 29, 2018
Merged
Conversation
jkotas
reviewed
Jun 28, 2018
| /// Check whether CultureData exists for specified language | ||
| /// This API is used for WindowsRuntimeResourceManager in System.Runtime.WindowsRuntime | ||
| /// </summary> | ||
| public static bool IsCultureDataExists(string language) |
Member
There was a problem hiding this comment.
This argument is not language. I would call this bool IsValidCulture(string cultureName) and put into WindowsRuntimeResourceManagerBase so that all resource glue is together.
jkotas
approved these changes
Jun 28, 2018
Author
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WindowsRuntimeResourceManager need to access CultureData to see whether a language is supported or not.
Add a public implementation CultureDataSupport for WindowsRuntimeResourceManager