Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Update Tizen CI docker image#17814

Merged
janvorli merged 5 commits intodotnet:masterfrom
gbalykov:update-tizen-docker-image
May 21, 2018
Merged

Update Tizen CI docker image#17814
janvorli merged 5 commits intodotnet:masterfrom
gbalykov:update-tizen-docker-image

Conversation

@gbalykov
Copy link
Member

@gbalykov gbalykov commented Apr 27, 2018

Update Tizen CI docker image to ubuntu 16.04

This seems to fix #17028. Related issue (https://github.com/dotnet/corefx/issues/28901)

cc @Dmitri-Botcharnikov @alpencolt

@gbalykov
Copy link
Member Author

@dotnet-bot test Tizen armel Cross Release Build

@gbalykov gbalykov changed the title [WIP] Update Tizen CI docker image Update Tizen CI docker image Apr 27, 2018
@gbalykov
Copy link
Member Author

@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test

@gbalykov
Copy link
Member Author

@jkotas could we reenable Tizen in default CI now?

@jkotas
Copy link
Member

jkotas commented Apr 27, 2018

@jkotas could we reenable Tizen in default CI now?

@RussKeldorph ?

@RussKeldorph
Copy link

@gbalykov Does this also address QEMU issues like #6298? If not, I suspect we won't be able to tolerate the spurious failures in the default CI jobs. If you aren't sure, we can do a trial run, on the condition that if the spurious failures return, we disable again.

@gbalykov
Copy link
Member Author

@RussKeldorph

Docker image now has newer version of QEMU. I've ran Tizen tests on this PR and there seems to be no problem with them. I agree with your idea to disable tests if spurious failures return.

I'll update this PR with enabled Tizen CI in default jobs and open same PR for corefx/core-setup.

@gbalykov
Copy link
Member Author

gbalykov commented May 8, 2018

@dotnet-bot test this please

@gbalykov gbalykov changed the title Update Tizen CI docker image [WIP] Update Tizen CI docker image May 10, 2018
@gbalykov gbalykov force-pushed the update-tizen-docker-image branch from d655ff1 to 75c4051 Compare May 10, 2018 10:35
@gbalykov
Copy link
Member Author

@dotnet-bot test Tizen armel Cross Release Build

@gbalykov
Copy link
Member Author

@dotnet-bot test this please

@gbalykov gbalykov force-pushed the update-tizen-docker-image branch from a4386dd to 16a64fd Compare May 15, 2018 12:46
@gbalykov
Copy link
Member Author

@dotnet-bot test Tizen armel Cross Release Build

@gbalykov gbalykov changed the title [WIP] Update Tizen CI docker image Update Tizen CI docker image May 16, 2018
@gbalykov
Copy link
Member Author

@RussKeldorph, could you, please, take a look?

]
],
'Tizen': [
'armem': [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbalykov should this be "armel" instead of "armem"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janvorli, this is simply revert of part of #17240. armem is used for ARM builds/runs using emulator.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok, thank you for the clarification!

@janvorli
Copy link
Member

@dotnet-bot test ci please

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@gbalykov gbalykov force-pushed the update-tizen-docker-image branch from 16a64fd to 8dc93e4 Compare May 21, 2018 11:17
@gbalykov
Copy link
Member Author

@dotnet-bot test ci please

@gbalykov
Copy link
Member Author

@dotnet-bot test Tizen armel Cross Release Build

@gbalykov
Copy link
Member Author

@janvorli, I've fully reverted commit, which disabled Tizen CI, so now "test ci please" should work. However, it seems that I can't run it. Could you, please, rerun it?

@janvorli
Copy link
Member

@dotnet-bot test ci please

@janvorli janvorli merged commit 338474d into dotnet:master May 21, 2018
@gbalykov
Copy link
Member Author

@janvorli Thank you!

nkaretnikov2 added a commit to nkaretnikov2/coreclr that referenced this pull request Aug 1, 2018
Based on "Update Tizen CI docker image (dotnet#17814)".
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tizen armel Cross Checked Innerloop Build and Test failing pretty much every PR

4 participants