This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix Incorrect Array Dereference When Clearing EventData.Reserved#17113
Merged
brianrob merged 1 commit intodotnet:masterfrom Mar 22, 2018
Merged
Fix Incorrect Array Dereference When Clearing EventData.Reserved#17113brianrob merged 1 commit intodotnet:masterfrom
brianrob merged 1 commit intodotnet:masterfrom
Conversation
Member
Author
|
Run EventSource tests: |
Member
Author
|
@dotnet-bot test Windows_NT x86 Checked corefx_baseline |
stephentoub
approved these changes
Mar 22, 2018
Member
Author
|
CoreFX Windows x86 failed due to unrelated System.Data.SqlClient.Tests failures. |
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Mar 22, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Mar 22, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Mar 22, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
ahsonkhan
pushed a commit
to dotnet/corefx
that referenced
this pull request
Mar 23, 2018
* Small tweaks to Dict asm size (dotnet/coreclr#17096) Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> * Moving Span APIs that allow skipping visibility checks to MemoryMarshal (#17087) Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> * Improve DateTime{Offset} "r" and "o" formatting performance (#17092) Two main changes: 1. Rewrote the formatting to use span, only to then discover that we already had almost exactly the same implementation in Utf8Formatter. As that one had some extra optimizations around JIT behaviors, I ported that over instead. 2. Avoided [ThreadStatic] lookups unless necessary. ToString/TryFormat for "o"/"O" improve by ~2.5x. ToString/TryFormat for "r"/"R" improve by ~3x. Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> * Rename {Try}Read/WriteMachineEndian to just {Try}Read/Write (#17106) Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> * Fix incorrect array dereference. (dotnet/coreclr#17113) Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> * Move Span APIs that allow skipping visibility checks to MemoryMarshal * Rename {Try}Read/WriteMachineEndian to just {Try}Read/Write * Update calls to BinaryPrimitives.ReadMachineEndian * Rename calls to ReadMachineEndian in System.Memory perf tests. * Add ApiCompatBaseline for UWP NETNative * Add to ApiCompatBaseline for UWP NETNative netstandard20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/28099.
With the change to no longer initialize locals in System.Private.CoreLib, EventData.Reserved must be manually initialized to zero for manifest-based ETW. This was done in #16283. This change fixes an instance of missing initialization due to an incorrect array index.
cc: @danmosemsft, @JeremyKuhne