This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Support docker cgroup limits#13488
Merged
janvorli merged 2 commits intodotnet:masterfrom Aug 21, 2017
Merged
Conversation
The parsing would find the wrong '-' in lines like this: 354 347 0:28 /system.slice/docker-654dd7b6b8bbfe1739ae3309b471e95ccc82b3a3f56b7879f0a811d68b5c4e1d.scope /sys/fs/cgroup/cpuacct,cpu ro,nosuid,nodev,noexec,relatime - cgroup cgroup rw,cpuacct,cpu
Member
Author
|
I've tested this as follows: Dockerfile |
janvorli
approved these changes
Aug 21, 2017
Member
janvorli
left a comment
There was a problem hiding this comment.
LGTM, thank you very much for finding and fixing it!
Member
|
@dotnet-bot test Tizen armel Cross Debug Build please |
sandreenko
pushed a commit
to sandreenko/coreclr
that referenced
this pull request
Aug 21, 2017
* Fix cgroup mountinfo parsing The parsing would find the wrong '-' in lines like this: 354 347 0:28 /system.slice/docker-654dd7b6b8bbfe1739ae3309b471e95ccc82b3a3f56b7879f0a811d68b5c4e1d.scope /sys/fs/cgroup/cpuacct,cpu ro,nosuid,nodev,noexec,relatime - cgroup cgroup rw,cpuacct,cpu * cgroup: don't append cgroup relative path for reading docker limits
Member
Author
|
Thanks @janvorli |
tmds
added a commit
to tmds/coreclr
that referenced
this pull request
Aug 22, 2017
* Fix cgroup mountinfo parsing The parsing would find the wrong '-' in lines like this: 354 347 0:28 /system.slice/docker-654dd7b6b8bbfe1739ae3309b471e95ccc82b3a3f56b7879f0a811d68b5c4e1d.scope /sys/fs/cgroup/cpuacct,cpu ro,nosuid,nodev,noexec,relatime - cgroup cgroup rw,cpuacct,cpu * cgroup: don't append cgroup relative path for reading docker limits
Member
Author
|
@janvorli I'm having a look at what commits could be picked to bring this to 2.0.x. |
Member
|
@tmds the release/2.0.0 branch is now frozen for the 2.0.1 release, we can back port it after it opens again. |
Member
|
@tmds I've ported these three commits to release/2.0.0 branch, so it will be part of the 2.0.2 release. |
Member
Author
|
Thanks @janvorli ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
354 347 0:28 /system.slice/docker-654dd7b6b8bbfe1739ae3309b471e95ccc82b3a3f56b7879f0a811d68b5c4e1d.scope /sys/fs/cgroup/cpuacct,cpu ro,nosuid,nodev,noexec,relatime - cgroup cgroup rw,cpuacct,cpu