This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add Dev/Ino fields to Interop.Sys.FileStatus#11070
Merged
stephentoub merged 1 commit intodotnet:masterfrom Apr 19, 2017
Merged
Conversation
ianhays
approved these changes
Apr 19, 2017
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Apr 19, 2017
Add Dev/Ino fields to Interop.Sys.FileStatus Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Apr 19, 2017
Add Dev/Ino fields to Interop.Sys.FileStatus Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 13, 2018
Add Dev/Ino fields to Interop.Sys.FileStatus Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 13, 2018
Add Dev/Ino fields to Interop.Sys.FileStatus Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 16, 2018
Add Dev/Ino fields to Interop.Sys.FileStatus Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 16, 2018
Add Dev/Ino fields to Interop.Sys.FileStatus Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix https://github.com/dotnet/corefx/issues/18521, I need to modify SystemNative_Stat and friends to pass back in the FileStatus struct the st_dev/st_ino values. But before I can do that in corefx, coreclr's version of FileStatus needs to be increased in size to contain the two additional fields; otherwise, attempting to change System.Native.so/dylib to write to those fields in corefx will stomp over memory when used by coreclr.
Contributes to https://github.com/dotnet/corefx/issues/18521
cc: @janvorli, @JeremyKuhne