This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Move files to shared CoreLib partition#10837
Merged
jkotas merged 1 commit intodotnet:masterfrom Apr 10, 2017
Merged
Conversation
Member
jkotas
commented
Apr 10, 2017
- Reconcile diffs with CoreRT as appropriate
- Deleted unused internal SuppressMergeCheckAttribute and XmlIgnoreMemberAttribute
jkotas
commented
Apr 10, 2017
clr.coreclr.props
Outdated
| <!-- Setting this to "false" works only for workstation GC, not server. --> | ||
| <FeatureSymDiff>true</FeatureSymDiff> | ||
| <FeatureReadyToRun Condition="'$(TargetArch)'!='arm64'">true</FeatureReadyToRun> | ||
| <FeatureReadyToRun>true</FeatureReadyToRun> |
Member
Author
There was a problem hiding this comment.
Mismatch between C++ makefiles and C# project files that I run into
Member
There was a problem hiding this comment.
Does this change behavior -- is it worth a separate PR in case it needs revert?
danmoseley
reviewed
Apr 10, 2017
| { | ||
| internal unsafe partial class Sys | ||
| { | ||
| [DllImport(Interop.Libraries.SystemNative, EntryPoint = "SystemNative_GetNonCryptographicallySecureRandomBytes")] |
Member
There was a problem hiding this comment.
I can't find this entry point.. mabye it's a generated name?
Member
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Oh it's in corefx. I don't understand how that kind of call works yet.
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Apr 10, 2017
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
added a commit
to dotnet/corert
that referenced
this pull request
Apr 10, 2017
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 13, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 13, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 16, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 16, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.